From owner-freebsd-geom@FreeBSD.ORG  Sat Apr 14 15:44:38 2012
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: geom@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A2006106566C;
	Sat, 14 Apr 2012 15:44:38 +0000 (UTC)
	(envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 6C00C8FC16;
	Sat, 14 Apr 2012 15:44:38 +0000 (UTC)
Received: from dhcp-192-168-2-14.wifi.xcllnt.net (atm.xcllnt.net [70.36.220.6])
	(authenticated bits=0)
	by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q3EFiRom057697
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Sat, 14 Apr 2012 08:44:32 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: text/plain; charset=iso-8859-1
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <4F88F966.5030300@semihalf.com>
Date: Sat, 14 Apr 2012 08:44:36 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <CB41CA4E-2AC0-4C62-905A-B4BCDBDD240A@xcllnt.net>
References: <EE2F4D7D-F6D9-48D4-923A-99DAA62698B2@xcllnt.net>
	<4F7A6A0B.5000308@semihalf.com> <4F88F966.5030300@semihalf.com>
To: Grzegorz Bernacki <gjb@semihalf.com>
X-Mailer: Apple Mail (2.1257)
Cc: geom@FreeBSD.org, fs@FreeBSD.org
Subject: Re: Review of projects/nand branch
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2012 15:44:38 -0000


On Apr 13, 2012, at 9:13 PM, Grzegorz Bernacki wrote:

Hi Gregorz,

It was good to finally meet you!

>>> o   In sbin/Makefile: we should have a distinct MK_NANDFS option
>>>     for use by the file system code.
>=20
> - Is a separate MK_NANDFS knob really needed? Other filesystems don't =
seem to
> follow this route
> - The sys/fs/nandfs is only included per kernel config option, other =
userspace
> components per MK_NAND
> - Do you really think it is useful to have NAND framework built =
without NANDFS
> and vice versa, the FS without userland tools for it?

I don't think it's *really* needed per se, but since nandfs is
a useful file system on any kind of storage media, I can see
that people may want the file system, but not the NAND framework
bits. I thought that keeping the distinction between the 2 (as
we do in the kernel with "options NANDFS" and "device nand") is
probably a good thing.

I leave it up to you. It's not of any real significance either
way...

Thanks for taking care of all the review comments!
Cheers,

--=20
Marcel Moolenaar
marcel@xcllnt.net