From owner-svn-src-all@FreeBSD.ORG Wed Jan 12 00:05:20 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73ECC106566B; Wed, 12 Jan 2011 00:05:20 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 9E82F8FC1D; Wed, 12 Jan 2011 00:05:19 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id p0BIeIqu029138; Tue, 11 Jan 2011 11:40:18 -0700 (MST) (envelope-from imp@bsdimp.com) Message-ID: <4D2CA410.108@bsdimp.com> Date: Tue, 11 Jan 2011 11:40:16 -0700 From: Warner Losh User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6 MIME-Version: 1.0 To: John Baldwin References: <201101092347.p09NlB4M060802@svn.freebsd.org> <201101101433.18847.jhb@freebsd.org> <4D2BE4F8.3030902@FreeBSD.org> <201101110847.24284.jhb@freebsd.org> In-Reply-To: <201101110847.24284.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Doug Barton , src-committers@freebsd.org Subject: Re: svn commit: r217213 - head/lib/bind X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2011 00:05:20 -0000 On 01/11/2011 06:47, John Baldwin wrote: > On Tuesday, January 11, 2011 12:04:56 am Doug Barton wrote: >> I have no objection to putting it back to the state that it was in at >> r209886, although frankly less diffs to RELENG_[78] without good reason >> make my life easier. > 209886 did not use MACHINE_CPUARCH for ISC_ATOMIC_ARCH, and in fact the file > is now back to the 209886 state (nwhitehorn did not change ISC_ATOMIC_ARCH > to use MACHINE_CPUARCH). > > Fixing this does create diffs to [78] because MACHINE_CPUARCH is not present > at all in [78], but that is because [78]'s handling of different endians for > mips, arm, etc. is deficient. You are likely stuck with using MACHINE_CPUARCH > for 9+ and MACHINE_ARCH for<= 8. I've created compatibility shims for MACHINE_CPUARCH in RELENG_8, but not for RELENG_7 (at least in some places, now that I go looking for it). I'm thinking seriously of MFCing it to make future MFCs easier, especially for some MIPS work that I've been doing. In -current, Doug's likely will operate correctly for quite some time. We're not going to change MACHINE_ARCH of i386 or amd64. At most, we'll change MACHINE_CPUARCH to x86, but that would be a lot of work to undertake in the whole tree... The only down-side is that it increases by two the number of MACHINE_ARCH instances that I need to audit when I sweep the tree looking for problems. If there's no good reason for the chaff, I change it. If there is, like this case, I note it as good and move on. While I'd prefer to have everything converted, I'm willing to be flexible when necessary... Warner