Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Mar 2019 01:49:36 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r345564 - projects/fuse2/sys/fs/fuse
Message-ID:  <201903270149.x2R1naYS015428@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Wed Mar 27 01:49:35 2019
New Revision: 345564
URL: https://svnweb.freebsd.org/changeset/base/345564

Log:
  fusefs: set fuse_init_in->max_readahead correctly
  
  The old value was correct only by coincidence.
  
  Sponsored by:	The FreeBSD Foundation

Modified:
  projects/fuse2/sys/fs/fuse/fuse_internal.c

Modified: projects/fuse2/sys/fs/fuse/fuse_internal.c
==============================================================================
--- projects/fuse2/sys/fs/fuse/fuse_internal.c	Wed Mar 27 00:24:57 2019	(r345563)
+++ projects/fuse2/sys/fs/fuse/fuse_internal.c	Wed Mar 27 01:49:35 2019	(r345564)
@@ -689,8 +689,12 @@ fuse_internal_send_init(struct fuse_data *data, struct
 	fiii = fdi.indata;
 	fiii->major = FUSE_KERNEL_VERSION;
 	fiii->minor = FUSE_KERNEL_MINOR_VERSION;
-	//XXX should probably be maxbcachebuf * 16
-	fiii->max_readahead = 4096 * 16;
+	/* 
+	 * fusefs currently doesn't do any readahead other than fetching whole
+	 * buffer cache block sized regions at once.  So the max readahead is
+	 * the size of a buffer cache block.
+	 */
+	fiii->max_readahead = maxbcachebuf;
 	fiii->flags = 0;
 
 	fuse_insert_callback(fdi.tick, fuse_internal_init_callback);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903270149.x2R1naYS015428>