From owner-svn-src-all@FreeBSD.ORG  Tue Aug 10 18:03:43 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 02E5B1065676;
	Tue, 10 Aug 2010 18:03:43 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id B696C8FC26;
	Tue, 10 Aug 2010 18:03:42 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o7AHsPLi076795;
	Tue, 10 Aug 2010 11:54:25 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Tue, 10 Aug 2010 11:54:57 -0600 (MDT)
Message-Id: <20100810.115457.1126759349893144516.imp@bsdimp.com>
To: hrs@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20100811.023235.13138059.hrs@allbsd.org>
References: <20100810.093656.167578749323544001.imp@bsdimp.com>
	<201008101623.o7AGNs7I042679@haluter.fromme.com>
	<20100811.023235.13138059.hrs@allbsd.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: src-committers@FreeBSD.org, jilles@stack.nl, svn-src-all@FreeBSD.org,
	olli@fromme.com, olli@FreeBSD.org, svn-src-head@FreeBSD.org, des@des.no
Subject: Re: svn commit: r211023 - head/usr.sbin/syslogd
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Aug 2010 18:03:43 -0000

In message: <20100811.023235.13138059.hrs@allbsd.org>
            Hiroki Sato <hrs@FreeBSD.org> writes:
: Oliver Fromme <olli@fromme.com> wrote
:   in <201008101623.o7AGNs7I042679@haluter.fromme.com>:
: 
: ol> -static int	validate(struct sockaddr *, const char *);
: ol> -static void	unmapped(struct sockaddr *);
: ol> +static int	validate(struct sockaddr_storage *, const char *);
: ol> +static void	unmapped(struct sockaddr_storage *);
: 
:  Why is s/struct sockaddr */struct sockaddr_storage */ needed here?
:  Using (struct sockaddr *) as an argument looks reasonable to me since
:  the struct sockaddr_storage is mostly for memory allocation, not for
:  access via pointer.

Because struct sockaddr * has a too loose alignment requirement for
later casting, while sockaddr_storage has the proper alignment.

Warner