From owner-svn-src-all@FreeBSD.ORG Mon Apr 29 23:20:05 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8710F3FA; Mon, 29 Apr 2013 23:20:05 +0000 (UTC) (envelope-from smh@freebsd.org) Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35]) by mx1.freebsd.org (Postfix) with ESMTP id 219971E0A; Mon, 29 Apr 2013 23:20:04 +0000 (UTC) Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534) id 0E72C20E7088B; Mon, 29 Apr 2013 23:19:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.multiplay.co.uk X-Spam-Level: ** X-Spam-Status: No, score=2.7 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX, FSL_HELO_NON_FQDN_1,HELO_NO_DOMAIN,RDNS_DYNAMIC,STOX_REPLY_TYPE autolearn=no version=3.3.1 Received: from r2d2 (46-65-172-4.zone16.bethere.co.uk [46.65.172.4]) by smtp1.multiplay.co.uk (Postfix) with ESMTP id C8DC120E70886; Mon, 29 Apr 2013 23:19:31 +0000 (UTC) Message-ID: From: "Steven Hartland" To: "Kenneth D. Merry" References: <201304261617.r3QGH58Q048395@svn.freebsd.org> <20130429225641.GA1375@nargothrond.kdm.org> Subject: Re: svn commit: r249939 - head/sys/cam/scsi Date: Tue, 30 Apr 2013 00:20:07 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Apr 2013 23:20:05 -0000 ----- Original Message ----- From: "Kenneth D. Merry" To: "Steven Hartland" Cc: ; ; Sent: Monday, April 29, 2013 11:56 PM Subject: Re: svn commit: r249939 - head/sys/cam/scsi > On Fri, Apr 26, 2013 at 16:17:05 +0000, Steven Hartland wrote: >> Author: smh >> Date: Fri Apr 26 16:17:04 2013 >> New Revision: 249939 >> URL: http://svnweb.freebsd.org/changeset/base/249939 >> >> Log: >> Added available delete methods discovery during device probe, including the >> maximum sizes for said methods, which are used when processing BIO_DELETE >> requests. This includes updating UNMAP support discovery to be based on >> SBC-3 T10/1799-D Revision 31 specification. >> >> Added ATA TRIM support to cam scsi devices via ATA Pass-Through(16) >> >> sys/cam/scsi/scsi_da.c: >> - Added ATA Data Set Management TRIM support via ATA Pass-Through(16) >> as a delete_method >> > > This adds a lot of unnecessary verbosity for devices that don't support ATA > passthrough. For example: > > (da7:iscsi4:0:0:0): ATA COMMAND PASS THROUGH(16). CDB: 85 08 0a 00 00 02 00 00 00 00 00 00 00 40 ec 00 > (da7:iscsi4:0:0:0): CAM status: SCSI Status Error > (da7:iscsi4:0:0:0): SCSI status: Check Condition > (da7:iscsi4:0:0:0): Retrying command (per sense data) > (2:2:0:0): ATA COMMAND PASS THROUGH(16). CDB: 85 08 0a 00 00 02 00 00 00 00 00 00 00 40 ec 00 > (2:2:0:0): Tag: 0x00f6, Type: 1 > (2:2:0:0): CTL Status: SCSI Error > (2:2:0:0): SCSI Status: Check Condition > (2:2:0:0): SCSI sense: ILLEGAL REQUEST asc:20,0 (Invalid command operation code) > (2:2:0:0): Command byte 0 is invalid > > (da8:iscsi4:0:0:1): ATA COMMAND PASS THROUGH(16). CDB: 85 08 0a 00 00 02 00 00 00 00 00 00 00 40 ec 00 > (da8:iscsi4:0:0:1): CAM status: SCSI Status Error > (da8:iscsi4:0:0:1): SCSI status: Check Condition > (da8:iscsi4:0:0:1): Retrying command (per sense data) > (da8:iscsi4:0:0:1): ATA COMMAND PASS THROUGH(16). CDB: 85 08 0a 00 00 02 00 00 00 00 00 00 00 40 ec 00 > (da8:iscsi4:0:0:1): CAM status: SCSI Status Error > (da8:iscsi4:0:0:1): SCSI status: Check Condition > (da8:iscsi4:0:0:1): Error 5, Retries exhausted > > That is with CTL and and trasz's new iSCSI initiator, but you should see it > with any CTL configuration. (And probably with any controller or device > that doesn't support ATA passthrough.) > > So, please: > - Check for the presence of VPD page 0x89 before sending an ATA > passthrough command. The spec (sat3r03 in this case) says that > it "shall" be implemented, so I think we can count on that. > - If the target returns an illegal request sense key, don't retry > again. The target will keep returning illegal request Thanks for the report Ken I'll check this on a card I know doesn't support pass-through. Regards Steve