From owner-svn-src-user@freebsd.org  Wed May 18 22:50:10 2016
Return-Path: <owner-svn-src-user@freebsd.org>
Delivered-To: svn-src-user@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 425D0B41066
 for <svn-src-user@mailman.ysv.freebsd.org>;
 Wed, 18 May 2016 22:50:10 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2E8B01B45;
 Wed, 18 May 2016 22:50:09 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u4IMo9Se047371
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 18 May 2016 15:50:09 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u4IMo9uC047370;
 Wed, 18 May 2016 15:50:09 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 18 May 2016 15:50:09 -0700
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Garrett Cooper <ngie@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: Re: svn commit: r299818 - user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd
Message-ID: <20160518225009.GN1015@FreeBSD.org>
References: <201605150110.u4F1AW92016063@repo.freebsd.org>
 <20160518224924.GM1015@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160518224924.GM1015@FreeBSD.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user/>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2016 22:50:10 -0000

On Wed, May 18, 2016 at 03:49:24PM -0700, Gleb Smirnoff wrote:
T> On Sun, May 15, 2016 at 01:10:32AM +0000, Garrett Cooper wrote:
T> G> Author: ngie
T> G> Date: Sun May 15 01:10:31 2016
T> G> New Revision: 299818
T> G> URL: https://svnweb.freebsd.org/changeset/base/299818
T> G> 
T> G> Log:
T> G>   Test laddr.s_addr against NULL, not 0
T> G> 
T> G> Modified:
T> G>   user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c
T> G> 
T> G> Modified: user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c
T> G> ==============================================================================
T> G> --- user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c	Sun May 15 00:54:21 2016	(r299817)
T> G> +++ user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c	Sun May 15 01:10:31 2016	(r299818)
T> G> @@ -1220,7 +1220,7 @@ snmpd_input(struct port_input *pi, struc
T> G>  		
T> G>  		ret = recv_dgram(pi, &laddr);
T> G>  
T> G> -		if (laddr.s_addr == 0) {
T> G> +		if (laddr.s_addr == NULL) {
T> G>  			msg.msg_control = NULL;
T> G>  			msg.msg_controllen = 0;
T> G>  		}
T> 
T> This change also seems incorrect. It isn't a pointer.

And I missed the next commit :)

-- 
Totus tuus, Glebius.