From owner-freebsd-current@FreeBSD.ORG Wed Jul 4 16:53:41 2007 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C00B216A468; Wed, 4 Jul 2007 16:53:41 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 39AD713C469; Wed, 4 Jul 2007 16:53:40 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l64Grdie033123; Wed, 4 Jul 2007 20:53:39 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru; s=default; t=1183568019; bh=VpUoZPfdgk6J2db6W3VQTSm8eRWsQNBuYF/Szm4 e9SQ=; l=1126; h=Received:Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=Qv6ALCVQMDwE5sr+LgQT mt/nrS1WQTdJqMu5LHfFcS9P1LyW6ky88oiLYi9HR25t/wv3RA3nLxJmsgzDkicK1zd bXAj9NQh71QvG8gWVegI4YUEQNs85YGs2Dn4920vWFO17bod1HK0nQ9FyWOi2s3fQWA RmcBXwUYpBmBA0dd0= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l64GrdZ2033122; Wed, 4 Jul 2007 20:53:39 +0400 (MSD) (envelope-from ache) Date: Wed, 4 Jul 2007 20:53:37 +0400 From: Andrey Chernov To: Robert Watson Message-ID: <20070704165336.GA33050@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Robert Watson , "Sean C. Farley" , freebsd-current , Michal Mertl References: <1183557221.1799.16.camel@genius.i.cz> <20070704143642.GA31254@nagual.pp.ru> <20070704150312.GB31683@nagual.pp.ru> <20070704101026.O77978@thor.farley.org> <20070704173905.T67251@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070704173905.T67251@fledge.watson.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-current , "Sean C. Farley" , Michal Mertl Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2007 16:53:41 -0000 On Wed, Jul 04, 2007 at 05:41:10PM +0100, Robert Watson wrote: > > I assume I'm not the only person with this concern, but -- shouldn't we > worry that subtle changes in the semantics of very basic and widely used > system APIs might not result in more of exactly this sort of problem? This happens due to improper putenv()->setenv() transition in sh code, not directly because of semantics change. F.e. it works in my commited code long ago. Very basic and widely used system's APIs (excepting BSD one) already do proper thing. > While I'm supportive of the general aim of improving the portability of our > APIs, environmental variables are managed by large numbers of programs in > rather subtle ways--do we generally feel that this recent work will > decrease or increase the number of subtle bugs? After all, we've changed > long-standing semantics for the APIs... Just re-read old discussion. Long-standing semantics most system agree (Sun, Linux) already do that way. Only BSD doesn't. No surprise than that old BSD-specific code is full of bugs and not portable. -- http://ache.pp.ru/