Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Apr 2016 21:25:11 +0200
From:      olli hauer <ohauer@gmx.de>
To:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r413604 - in head/Mk: . Scripts
Message-ID:  <57153497.5000000@gmx.de>
In-Reply-To: <201604181839.u3IIdjhn065995@repo.freebsd.org>
References:  <201604181839.u3IIdjhn065995@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-04-18 20:39, Mathieu Arnold wrote:
> Author: mat
> Date: Mon Apr 18 18:39:44 2016
> New Revision: 413604
> URL: https://svnweb.freebsd.org/changeset/ports/413604
> 
> Log:
>   Extract the users/groups creation into a separate shell script.
>   
>   This adds a few features:
>   - it checks that the UID line has the right number of fields [1]
>   - it tells the user that there are groups that he may want to remove [2]
>   
>   PR:		208800, 173318 [1], 157546 [2]  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208800  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208800
>   Submitted by:	mat
>   Sponsored by:	Absolight
>   Differential Revision:	https://reviews.freebsd.org/D5939
> 
...
> Modified: head/Mk/bsd.port.mk
> ==============================================================================
> --- head/Mk/bsd.port.mk	Mon Apr 18 18:17:19 2016	(r413603)
> +++ head/Mk/bsd.port.mk	Mon Apr 18 18:39:44 2016	(r413604)
> @@ -1245,6 +1245,10 @@ GID_OFFSET?=	0
>  # alpha numeric sort order
>  USERS_BLACKLIST=	_dhcp _pflogd auditdistd bin bind daemon games hast kmem mailnull man news nobody operator pop proxy root smmsp sshd toor tty uucp www
>  
> +# predefined accounts from src/etc/group
> +# alpha numeric sort order
> +GROUPS_BLACKLIST=	_dhcp _pflogd audit authpf bin bind daemon dialer ftp games guest hast kmem mail mailnull man network news nobody nogroup operator proxy smmsp sshd staff sys tty unbound uucp wheel www
...


Hi Mathieu,

nice rework :)

I've done a quick compare of the USERS_BLACKLIST and /etc/ftpusers on a 10.x system and noted "unbound" is missing in both BLACKLISTS.
Would you mind to extend the BLACKLIST's?

-- 
olli



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57153497.5000000>