From owner-svn-src-all@FreeBSD.ORG Wed Oct 21 14:11:57 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 209731065672; Wed, 21 Oct 2009 14:11:57 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au [211.29.132.188]) by mx1.freebsd.org (Postfix) with ESMTP id AD11B8FC14; Wed, 21 Oct 2009 14:11:56 +0000 (UTC) Received: from c122-106-156-249.carlnfd1.nsw.optusnet.com.au (c122-106-156-249.carlnfd1.nsw.optusnet.com.au [122.106.156.249]) by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n9LEBDSm003437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Oct 2009 01:11:14 +1100 Date: Thu, 22 Oct 2009 01:11:12 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Remko Lodder In-Reply-To: <7E425E81-2ACC-46F8-B864-169CDBFBB03B@elvandar.org> Message-ID: <20091022005227.A12866@delplex.bde.org> References: <200910211015.n9LAFQwY094532@svn.freebsd.org> <20091021222805.I12783@delplex.bde.org> <7E425E81-2ACC-46F8-B864-169CDBFBB03B@elvandar.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, Remko Lodder , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, Bruce Evans Subject: Re: svn commit: r198316 - head/sbin/tunefs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2009 14:11:57 -0000 On Wed, 21 Oct 2009, Remko Lodder wrote: > I'll try to implement your suggestions in a patch. Hopefully I'll have that > available later today. Can I send it over to you for reviewal so that > we are sure to have the correct fix ? It turned out to be mostly a kernel bug (I think -- I most don't use kernels with the bug), so fixing it is not very easy. The man page should just say something like "... should (but does not ) work on ". should be replaced by a list of what doesn't work (but should) and should be replaced by something like "file systems mounted r/o" (if that is what "active" should mean now).o NetBSD's 2005 version says: % BUGS % This program should work on mounted and active file systems. Because the % super-block is not kept in the buffer cache, the changes will only take % effect if the program is run on unmounted file systems. To change the % root file system, the system must be rebooted after the file system is % tuned. "mounted and active" is as unclear as "active". The rotted words about rebooting seem to have come from here -- I just noticed that they are very recent additions to FreeBSD's tunefs.8. They were added in 2007 8 years after they stopped applying. Bah, they aren't evem wrong like that: allthough they are identical to NetBSD, they have a completely different meaning. In NetBSD they are related to the buffer cache as dsecribed above, but in FreeBSD they are a special case for soft updates, as described only in their log message. It takes a full mount to get the soft updates flag looked at, so the remount done by tunefs doesn't work for changes to the soft updates flag. So you can't just remove the second sentence, but must reword it to say something relevant. Bruce