From owner-cvs-src@FreeBSD.ORG Sun Apr 3 10:29:56 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10EA516A4CE; Sun, 3 Apr 2005 10:29:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECBDD43D31; Sun, 3 Apr 2005 10:29:55 +0000 (GMT) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j33ATtHQ021545; Sun, 3 Apr 2005 10:29:55 GMT (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j33ATtAX021544; Sun, 3 Apr 2005 10:29:55 GMT (envelope-from jeff) Message-Id: <200504031029.j33ATtAX021544@repoman.freebsd.org> From: Jeff Roberson Date: Sun, 3 Apr 2005 10:29:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_extern.h ffs_softdep.c ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2005 10:29:56 -0000 jeff 2005-04-03 10:29:55 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_extern.h ffs_softdep.c ffs_vfsops.c Log: - Move the contents of softdep_disk_prewrite into ffs_geom_strategy to fix two bugs. - ffs_disk_prewrite was pulling the vp from the buf and checking for COPYONWRITE, when really it wanted the vp from the bufobj that we're writing to, which is the devvp. This lead to us skipping the copy on write to all file data, which significantly broke snapshots for the last few months. - When the SOFTUPDATES option was not included in the kernel config we would also skip the copy on write check, which would effectively disable snapshots. - Remove an invalid mp_fixme(). Debugging tips from: mckusick Reported by: iedowse, others Discussed with: phk Revision Changes Path 1.69 +0 -1 src/sys/ufs/ffs/ffs_extern.h 1.180 +0 -29 src/sys/ufs/ffs/ffs_softdep.c 1.288 +21 -2 src/sys/ufs/ffs/ffs_vfsops.c