From owner-freebsd-hackers Fri Jan 10 18:05:47 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id SAA18626 for hackers-outgoing; Fri, 10 Jan 1997 18:05:47 -0800 (PST) Received: from frmug.org (frmug-gw.frmug.org [193.56.58.252]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id SAA18621 for ; Fri, 10 Jan 1997 18:05:43 -0800 (PST) Received: (from uucp@localhost) by frmug.org (8.8.2/8.8.2/frmug-1.3) with UUCP id DAA13007 for hackers@FreeBSD.org; Sat, 11 Jan 1997 03:05:40 +0100 (MET) Received: from localhost (localhost [127.0.0.1]) by xp11.frmug.org (8.8.4/8.7.3/xp11-uucp-1.1) with ESMTP id CAA28453 for ; Sat, 11 Jan 1997 02:42:12 +0100 (CET) Message-Id: <199701110142.CAA28453@xp11.frmug.org> To: hackers@FreeBSD.org Subject: unused variable in su Date: Sat, 11 Jan 1997 02:42:11 +0100 From: "Philippe Charnier" Sender: owner-hackers@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk Hello, In /usr/src/usr.bin/su/su.c, I get: line 101: char shellbuf[MAXPATHLEN]; line 171: shell = strcpy(shellbuf, pwd->pw_shell); Shellbuf is not referenced elsewhere, is there any reason not to remove shellbuf (and adjust line 171), or is there a side effect I don't see? ------ ------ Philippe Charnier charnier@lirmm.fr (smtp) charnier@xp11.frmug.org (uucp) ``a PC not running FreeBSD is like a venusian with no tentacles'' ------------------------------------------------------------------------