From owner-p4-projects@FreeBSD.ORG Tue Mar 4 14:30:29 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9D5EB1065671; Tue, 4 Mar 2008 14:30:29 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CADC1065674 for ; Tue, 4 Mar 2008 14:30:29 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4C3528FC22 for ; Tue, 4 Mar 2008 14:30:29 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m24EUTo7008146 for ; Tue, 4 Mar 2008 14:30:29 GMT (envelope-from rrs@cisco.com) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m24EUTfg008144 for perforce@freebsd.org; Tue, 4 Mar 2008 14:30:29 GMT (envelope-from rrs@cisco.com) Date: Tue, 4 Mar 2008 14:30:29 GMT Message-Id: <200803041430.m24EUTfg008144@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to rrs@cisco.com using -f From: "Randall R. Stewart" To: Perforce Change Reviews Cc: Subject: PERFORCE change 136818 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 14:30:30 -0000 http://perforce.freebsd.org/chv.cgi?CH=136818 Change 136818 by rrs@rrs-mips2-jnpr on 2008/03/04 14:29:51 Hmm, not sure why p4 did what it did. This change (or maybe the previous one that did not allow email) takes and puts in a fix for the way break is handled by this device. We will re-read the lsr, then check it again, if its says there is data, read it and get the '0' char and discard it. This seems to be a shadow character that comes in with every break. Note that in uart_core (or tty), when we see the break we send in the break as a 0, not a TTY_BI, this is probably a bug. Affected files ... .. //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/uart_dev_oct16550.c#16 edit Differences ... ==== //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/uart_dev_oct16550.c#16 (text+ko) ====