Date: Wed, 26 Oct 2011 10:46:48 +0200 From: Ed Schouten <ed@80386.nl> To: Garrett Cooper <yanegomi@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226785 - head Message-ID: <20111026084648.GF63910@hoeg.nl> In-Reply-To: <4E5789B4-3370-4EE0-A5BE-A753070E0FD6@gmail.com> References: <201110260749.p9Q7nlj3038764@svn.freebsd.org> <4E5789B4-3370-4EE0-A5BE-A753070E0FD6@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--65ImJOski3p8EhYV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Garrett,
* Garrett Cooper <yanegomi@gmail.com>, 20111026 09:54:
> I addressed the overall issue a bit more thoroughly via bin/143830 .
> Could you take a look at that PR and let me know what you think of it?
The patch looks okay, but I think it can be simplified. Maybe we should
get rid of all the `RESCUE' bits from the atmconfig source code itself
and add something like this to the Makefile:
=2Eif !defined(RESCUE) && ${MK_BNSMP} !=3D "no"
CFLAGS+=3D -DWITH_BSNMP
=2Eendif
That way you can simply use `#ifdef WITH_BSNMP' throughout the source
files.
Thanks,
--=20
Ed Schouten <ed@80386.nl>
WWW: http://80386.nl/
--65ImJOski3p8EhYV
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iQIcBAEBAgAGBQJOp8j4AAoJEG5e2P40kaK7OAYP/RivBi2KG07kmVRsQ+gK5mAv
hjl/gkrwyXp1TGsRfdgRix5p4OyWxJIAIda8YJt41MxdVEDXtuG75iLgAJCT+H/r
Dh5q1dscb8ma4WlXabPsH5RgEn4dwZvLoxRROqzLObBfFYCOPKugO+z0DrIgZ4OQ
cCkCcp0nPt4GQ6rRu/Lki8EWZJGPEfxiZ8UmI6U7rOWu4GDKKkyHXDUtKJrWaBqO
allav3z9/sDHrLGucC52sBVSLRxEuYTxdfDeri25dPcjDXjexdzZnvos8ubqYI+L
VzNvF7Vbw8iZt104RuhmLjeOWlXq4rkEq+sN4ANju3JVEsligEm0zQ89hqSQjZP6
tGmllf1xfqDpuzgm3uvyGo4Zdy/N/rt8FdhE3ykmrrRkWcgriMzwX0TFzm0Nro+A
dOZBzUlWEPSN6vfdS1y+GlOFH+qwRb9LsrzQMRBHGVsSQ4Fl3gpHjgztcmq5JS0u
hrpz9VfjrZZDaHDewJ7ErICjC65ChFTplr3itH4GN6pAnpz8J04mtaAL0PlNlCbo
YiVWbNcthJSzOG8Fam+DNyPCEAY9QqIzc4IWXdU2iVaxOzZ2fdZqpOD8AwBGbQIZ
GLxqY5/BmI1C//gsH9WWNgKf8H/eoneNI7bBGp1F3FTC1/N6/O6Nn4n8jT8rwrCp
It1sZhUi+46riNc05t4s
=2kid
-----END PGP SIGNATURE-----
--65ImJOski3p8EhYV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111026084648.GF63910>