From owner-svn-src-head@freebsd.org Tue Sep 22 20:48:29 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1C8483F688D; Tue, 22 Sep 2020 20:48:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bwtgd00gMz4c1g; Tue, 22 Sep 2020 20:48:29 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D2C1C1E4F8; Tue, 22 Sep 2020 20:48:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f171.google.com with SMTP id q63so20568221qkf.3; Tue, 22 Sep 2020 13:48:28 -0700 (PDT) X-Gm-Message-State: AOAM532csQJgimL4nOXcxM5AYJLkpXpUFn06CAmTaBigmP/vElk5tGSR lEsWwduJIuA1nPdzYQiJ5p1QMsKtT8u4BuhVKDE= X-Google-Smtp-Source: ABdhPJwGIFfeOX0aiAX1kKuF9sUPZhk0H5CEwuAxXLMgseqvWA0hZ4CsO1A7uVMvuBa+2IkqSgUrbCpTuUV9831iPtw= X-Received: by 2002:a05:620a:4fb:: with SMTP id b27mr7088707qkh.120.1600807708492; Tue, 22 Sep 2020 13:48:28 -0700 (PDT) MIME-Version: 1.0 References: <202009112049.08BKnavL032212@repo.freebsd.org> In-Reply-To: <202009112049.08BKnavL032212@repo.freebsd.org> From: Kyle Evans Date: Tue, 22 Sep 2020 15:48:15 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r365643 - head/bin/cp To: Alan Somers Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 20:48:29 -0000 On Fri, Sep 11, 2020 at 3:49 PM Alan Somers wrote: > > Author: asomers > Date: Fri Sep 11 20:49:36 2020 > New Revision: 365643 > URL: https://svnweb.freebsd.org/changeset/base/365643 > > Log: > cp: fall back to read/write if copy_file_range fails > > Even though copy_file_range has a file-system agnostic version, it still > fails on devfs (perhaps because the file descriptor is non-seekable?) In > that case, fallback to old-fashioned read/write. Fixes > "cp /dev/null /tmp/null" > Hi, Any objection to adding a quick UPDATING entry for this? I'm seeing occasional reports of this breakage as recent as today on IRC from folks that were a little bit thrown off by this because it throws up fairly far into the build and looks like a stand build regression instead of a cp regression. Thanks, Kyle Evans