From owner-svn-ports-all@freebsd.org Sun Apr 12 20:47:19 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A236B2A85B6; Sun, 12 Apr 2020 20:47:19 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 490kMW3pVYz4d1p; Sun, 12 Apr 2020 20:47:19 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7DED17A82; Sun, 12 Apr 2020 20:47:19 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 03CKlJYr048784; Sun, 12 Apr 2020 20:47:19 GMT (envelope-from madpilot@FreeBSD.org) Received: (from madpilot@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 03CKlJNZ048783; Sun, 12 Apr 2020 20:47:19 GMT (envelope-from madpilot@FreeBSD.org) Message-Id: <202004122047.03CKlJNZ048783@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: madpilot set sender to madpilot@FreeBSD.org using -f From: Guido Falsi Date: Sun, 12 Apr 2020 20:47:19 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: svn commit: r531556 - in branches/2020Q2/x11/libxfce4menu: . files X-SVN-Group: ports-branches X-SVN-Commit-Author: madpilot X-SVN-Commit-Paths: in branches/2020Q2/x11/libxfce4menu: . files X-SVN-Commit-Revision: 531556 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2020 20:47:19 -0000 Author: madpilot Date: Sun Apr 12 20:47:19 2020 New Revision: 531556 URL: https://svnweb.freebsd.org/changeset/ports/531556 Log: MFH: r531554 x11/libxfce4menu: Fix leaked keygrabs when layout changes As diagnosed by Jethro Nederhof, xfce-shortcuts-grabber.c attempts to update grabbed key shortcuts when xkeyboard layout changes. Unfortunately, it had no memory of which keycodes it has actually grabbed. Instead, it attempted to ungrab the *new* keycode, which obviously doesn't actually ungrab those codes. This went unnoticed for some time, probably because nothing collided with important keys. Recently, a default PrintScreen shortcut was added to Xfce, which for whatever reason seems to collide with Up in initial layout. When the kbd layout changes, the shortcut ungrabs the *new* Printscreen keycode and then re-grabs the same keycode, leaving the Up keycode grabbed. Fix this by giving xfce-shortcuts-grabber some memory of which keycodes it has grabbed. When it grabs a key, it remembers the keycode it grabbed in the XfceKey object. When it ungrabs a key, it ungrabs the keycodes in the XfceKey object, rather than those for the new keyboard layout. PR: 244290 Reported by: Aryeh Friedman , many others Approved by: madpilot Differential Revision: https://reviews.freebsd.org/D24338 Approved by: portmgr (blanket, runtime fix) Added: branches/2020Q2/x11/libxfce4menu/files/ - copied from r531554, head/x11/libxfce4menu/files/ Modified: branches/2020Q2/x11/libxfce4menu/Makefile Directory Properties: branches/2020Q2/ (props changed) Modified: branches/2020Q2/x11/libxfce4menu/Makefile ============================================================================== --- branches/2020Q2/x11/libxfce4menu/Makefile Sun Apr 12 20:26:31 2020 (r531555) +++ branches/2020Q2/x11/libxfce4menu/Makefile Sun Apr 12 20:47:19 2020 (r531556) @@ -3,6 +3,7 @@ PORTNAME= libxfce4menu PORTVERSION= 4.14.1 +PORTREVISION= 1 CATEGORIES= x11 xfce MASTER_SITES= XFCE DISTNAME= libxfce4ui-${DISTVERSIONFULL}