From owner-svn-src-stable@freebsd.org  Thu Aug 16 16:18:39 2018
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8015106C9C6;
 Thu, 16 Aug 2018 16:18:39 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5B1498AF38;
 Thu, 16 Aug 2018 16:18:39 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com
 [209.85.208.178])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G3" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id ED2CB1EC3D;
 Thu, 16 Aug 2018 16:18:38 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-lj1-f178.google.com with SMTP id j19-v6so4130370ljc.7;
 Thu, 16 Aug 2018 09:18:38 -0700 (PDT)
X-Gm-Message-State: AOUpUlHft9YcBIbly9LJBEAK5giYmPJtncW4qSZ6kY8uy5+HxUEsFaqK
 4+rOR/noqNtS3K2ip2dWVM62svr1s31gfwpmeV4=
X-Google-Smtp-Source: AA+uWPz+wKz7DzDgkrZIMWQDhKBHxYiOX7ENVhC1ErPklZxJCS9fjn+1hoW9RPLPS2I0ieBZJZg5yP/NIsSk1PEcU+A=
X-Received: by 2002:a2e:2b0e:: with SMTP id
 q14-v6mr21006787lje.147.1534436317603; 
 Thu, 16 Aug 2018 09:18:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Thu, 16 Aug 2018 09:18:17
 -0700 (PDT)
In-Reply-To: <201808160124.w7G1O1mb051118@pdx.rh.CN85.dnsmgr.net>
References: <201808160118.w7G1IL90006511@repo.freebsd.org>
 <201808160124.w7G1O1mb051118@pdx.rh.CN85.dnsmgr.net>
From: Kyle Evans <kevans@freebsd.org>
Date: Thu, 16 Aug 2018 11:18:17 -0500
X-Gmail-Original-Message-ID: <CACNAnaF3TqdGUXs4Y1mb+hWh1j0_e5UN6LFU8=PhLkuevK=mCQ@mail.gmail.com>
Message-ID: <CACNAnaF3TqdGUXs4Y1mb+hWh1j0_e5UN6LFU8=PhLkuevK=mCQ@mail.gmail.com>
Subject: Re: svn commit: r337884 - stable/11/bin/ls
To: "Rodney W. Grimes" <rgrimes@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org, 
 Warner Losh <imp@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2018 16:18:39 -0000

On Wed, Aug 15, 2018 at 8:24 PM, Rodney W. Grimes
<freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
>> Author: kevans
>> Date: Thu Aug 16 01:18:20 2018
>> New Revision: 337884
>> URL: https://svnweb.freebsd.org/changeset/base/337884
>>
>> Log:
>>   Revert r337826: MFC of ls(1) COLORTERM honoring
>>
>>   It was not ready, and was much-objected-to.
>
> Thanks, just objected to, not much.
> I think once the --color=foo and the NULL COLORTERM
> fix goes in this should work as expected and not
> cause the issue seen by the user, or if it does
> I can tell them how to get color VIM, but not
> color ls without too much magic.
>

I've opened a review for my --color=foo implementation here:
https://reviews.freebsd.org/D16741

Please take a look when you have time.

Thanks,

Kyle Evans