From owner-cvs-all  Tue Jul 10 11: 3:18 2001
Delivered-To: cvs-all@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3528037B408; Tue, 10 Jul 2001 11:03:13 -0700 (PDT)
	(envelope-from mike@coffee.q9media.com)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.2) id f6AIIeq20534;
	Tue, 10 Jul 2001 14:18:40 -0400 (EDT)
	(envelope-from mike)
Date: Tue, 10 Jul 2001 14:18:40 -0400 (EDT)
Message-Id: <200107101818.f6AIIeq20534@coffee.q9media.com>
To: Mark Murray <markm@FreeBSD.org>
From: Mike Barcroft <mike@q9media.com>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpam/libpam pam_mod_misc.h pam_std_option.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Mark Murray <markm@FreeBSD.org> writes:
> markm       2001/07/10 09:59:31 PDT
>
>   Modified files:
>     lib/libpam/libpam    pam_mod_misc.h pam_std_option.c 
>   Log:
>   Fix a horrible bug introduced by myself where the options collection
>   keeps on growing as the module stack is parsed.
>   
>   Revision  Changes    Path
>   1.5       +2 -2      src/lib/libpam/libpam/pam_mod_misc.h
>   1.5       +19 -10    src/lib/libpam/libpam/pam_std_option.c

[...]
> +			found = 0;
> +			for (i = 0; std_options[i].name; i++)
> +				if (strcmp((char *)oo->name,
> +				    std_options[i].name) == 0)
> +					found = 1;
> +			if (!found) {
> +				std_options[j].name = oo->name;
> +				std_options[j].value = oo->value;
> +				j++;
> +			}
[...]

Shouldn't there be a break in the for loop after found is set?


Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message