From owner-freebsd-net@FreeBSD.ORG Tue Sep 4 02:06:30 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70E7816A419 for ; Tue, 4 Sep 2007 02:06:30 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id E272213C494 for ; Tue, 4 Sep 2007 02:06:29 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 30D73690FA0 for ; Tue, 4 Sep 2007 02:47:55 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id B0B376910A1; Tue, 4 Sep 2007 02:47:54 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=AWL, BAYES_00, FORGED_RCVD_HELO, RCVD_IN_NJABL_DUL,RCVD_IN_SORBS_DUL autolearn=no version=3.1.7 Received: from epsilon.local (87-196-23-68.net.novis.pt [87.196.23.68]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by core.fnop.net (Postfix) with ESMTP id 5F7E0690FA0 for ; Tue, 4 Sep 2007 02:47:51 +0100 (WEST) Message-ID: <46DCB831.3030207@fnop.net> Date: Tue, 04 Sep 2007 02:43:13 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: freebsd-net@freebsd.org Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Killing IPTOS_CE and IPTOS_ECT X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2007 02:06:30 -0000 Hi, I'm working on TCP ECN support and I would like to kill these defines from netinet/ip.h #if 1 /* ECN RFC3168 obsoletes RFC2481, and these will be deprecated soon. */ #define IPTOS_CE 0x01 #define IPTOS_ECT 0x02 #endif The are outdated and should no longer be used because that RFC has been obsoleted. RFC 3168 uses a bit different bits: #define IPTOS_ECN_NOTECT 0x00 /* not-ECT */ #define IPTOS_ECN_ECT1 0x01 /* ECN-capable transport (1) */ #define IPTOS_ECN_ECT0 0x02 /* ECN-capable transport (0) */ #define IPTOS_ECN_CE 0x03 /* congestion experienced */ #define IPTOS_ECN_MASK 0x03 /* ECN field mask */ The only consumer of the RFC 2481 defines is sbin/ipfw/ipfw2.c and luigi@ accepted the attached patch. Does anyone have any objection against the removal ? Regards. -- Rui Paulo