Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Sep 2007 02:43:13 +0100
From:      Rui Paulo <rpaulo@fnop.net>
To:        freebsd-net@freebsd.org
Subject:   Killing IPTOS_CE and IPTOS_ECT
Message-ID:  <46DCB831.3030207@fnop.net>

next in thread | raw e-mail | index | archive | help
Hi,
I'm working on TCP ECN support and I would like to kill these defines 
from netinet/ip.h

#if 1
/* ECN RFC3168 obsoletes RFC2481, and these will be deprecated soon. */
#define IPTOS_CE                0x01
#define IPTOS_ECT               0x02
#endif

The are outdated and should no longer be used because that RFC has been 
obsoleted. RFC 3168 uses a bit different bits:
#define IPTOS_ECN_NOTECT        0x00    /* not-ECT */
#define IPTOS_ECN_ECT1          0x01    /* ECN-capable transport (1) */
#define IPTOS_ECN_ECT0          0x02    /* ECN-capable transport (0) */
#define IPTOS_ECN_CE            0x03    /* congestion experienced */
#define IPTOS_ECN_MASK          0x03    /* ECN field mask */

The only consumer of the RFC 2481 defines is sbin/ipfw/ipfw2.c and 
luigi@ accepted the attached patch.

Does anyone have any objection against the removal ?

Regards.
-- 
Rui Paulo



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46DCB831.3030207>