From nobody Mon Nov 17 17:39:30 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d9FPJ3dRyz6GccK for ; Mon, 17 Nov 2025 17:39:48 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d9FPH6xcqz3hy3 for ; Mon, 17 Nov 2025 17:39:47 +0000 (UTC) (envelope-from adamw@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763401188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SbiuX/HmhYvssLuWHxpI94KM9FPAZHJ+SZEIybIwUms=; b=btr6cMrbZv1Ptq8nYZnAIGhKIMlFkMy/CR6RUUJcRWoLdG/ZKND5oOW95DX86u4BZE5whV HsTsfx88YydKhcgyrE4FoQ5IPryTM9QafWLzJIC4PV0u9QFFYES60Q2eFwpvM0gZj0UTbF 1Nq1dsMKMQj+fRuRk3ExOptNpmC+e8hb12iqgmdIn7txxu8lGj1vcZpHvKI56euxGUc48q qtkCCD3+H4Q5uw7hzqP8X8lH8tP3LLVHRDgFUqsC70K5qsH/sT1kUCd+pFkjxol6TVy+Wa 15vBEFGq5U/pDS+bM5s6fSRR//gLAMDDBcqW/8Gq5JS1AP43LN6adxKt28t/hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763401188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SbiuX/HmhYvssLuWHxpI94KM9FPAZHJ+SZEIybIwUms=; b=Dr+in5lopPEsozcaN+pTpisbF+zqiH5BbZEQ/vv45aOhNMAhT8ZT+ZGVYW77yfQyB2I2ya imXdxQjOV9izPTYH6VpClgt6UVSl1FdMmefuAriVD2h6/ihJLTbtkD6iv4C5ixOGLZET24 wxNAkTsZ7VF1uASAytg40mKvCnPHN1LtQEyl2V1i1n1OHQhcJ2oFUGXKBsASiJ17W/faH7 63vtjdQ80Lvf+amMeJrLE5oqzuAM0u29jL8C2mU4JZkr/fURJT26tIE9rjq8S607R5ccom Gh2VkKLf4hGUqSHa3b8PgodyjBpEKNGnUplNvRoUjpSNillKkieKW2qigOnI1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763401188; a=rsa-sha256; cv=none; b=nHagBQrXsI7CxiuLK9SIFnckx1IFcoXp4ZIRqRitQb+patLmqUC5rSrsd80P8nr03IDO5v gakh6mMxhCdqbkzmimqwnN8HbDAC9EDHMNrbbZcBjE4mtVK0qi6LNqImveZat6+Te+K9Jm 0uOvMCErRz5RFuYcxe7In22NgzHC2+Re7vZ/luxYZ7bplhSkjQB8YyGVqVD8fGLJ1CEHbI AePn1C2nDpGtfsoKY3gSxVWFtBA1/+wvAfArb0kEO3wsh49UMKsYURbYz+SSS6sgh1AGXz arB9qXwGGTEnhdAbGTaMganH7R0nFSpufor2NnyhbL4uyUsxMnqq3caf1LumJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: adamw/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4d9FPH5ZBFzCBW for ; Mon, 17 Nov 2025 17:39:47 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-786572c14e3so46120097b3.2 for ; Mon, 17 Nov 2025 09:39:47 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX9ZlmQS080oyam/JNHUS0f87nNBk1vUm3k1ipsbjCGJXDDGzcJcVo4a4YdtSUvusXoIktTMZBHqwX7Kj4kHEkjAkkl/tHb@freebsd.org X-Gm-Message-State: AOJu0YyQJuBZCff6dvb+c/VZZXQm9JY9O+FVi3R4r5aFnJQ1nApc4rGk SBtBFFm1z/dhadtLn/+9etVJHXpOrKMuQtM6rdHQiArBCxqKeGiROfEoSYpXHwRgz6kUjG2pOZL 8MzWzrjesyoUJI/W4Fc4GB8RN3ubgPhaogzoQUpOALQ== X-Google-Smtp-Source: AGHT+IEDUBNBXODZ7Bga8vqB6XuoHvo2cup4r5+PBnCtm2X7ygiYuR7YZ4aJW1CjN11uHHhBtdpNulN+TDmYkxFFBiM= X-Received: by 2002:a05:690e:2514:20b0:641:f5bc:6949 with SMTP id 956f58d0204a3-641f5bc6ebamr5959638d50.77.1763401186916; Mon, 17 Nov 2025 09:39:46 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202511150000.5AF00UV0020031@gitrepo.freebsd.org> <1806919.NDq42KOioK@mercury> <4220452.uxbk0vzbMu@mercury> In-Reply-To: From: Adam Weinberger Date: Mon, 17 Nov 2025 12:39:30 -0500 X-Gmail-Original-Message-ID: X-Gm-Features: AWmQ_bm2SQ3ffBRty0EmCHEE_RIzfJquuN4E2rhClWf1F6teKL-pG1CihhIlZbU Message-ID: Subject: Re: Literal text WWW in ports Makefile To: Chris Cc: ports-committers@freebsd.org, Zsolt Udvari , Nuno Teixeira , Max Brazhnikov , =?UTF-8?Q?Jes=C3=BAs_Daniel_Colmenares_Oviedo?= , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, DtxdF@disroot.org, portmgr@freebsd.org Content-Type: multipart/alternative; boundary="00000000000057d81c0643cdd54d" --00000000000057d81c0643cdd54d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 17, 2025 at 12:12=E2=80=AFPM Chris wrot= e: > On 2025-11-15 12:21, Max Brazhnikov wrote: > > On Sat, 15 Nov 2025 19:43:26 +0100 Zsolt Udvari wrote: > >> On Sat, Nov 15, 2025 at 09:16:30PM +0300, Max Brazhnikov wrote: > >> > WWW also was a literal text when it just migrated to Makefile. Why i= t > should > >> > be obfuscated now? No difference for the make, but less convenient > for humans: > >> > plain text url can be opened from the editor without running the mak= e. > >> > >> The github, gitlab and pear set a WWW (if it isn't defined in Makefile= ) > so > >> you can't open the url without running make. If you want see plain tex= t > >> url should remove these definitions from Mk/bsd.sites.mk and > > > > I'm ok with this, framework may set WWW for ports, and ports can > redefine it > > if needed. But if WWW is explicitly set in the Makefile it should be > plain > > url. > > If either is possible. Why should it not be what is easiest or most > efficient > for the > Maintainer/Developer at the time? > Because it should be what is most helpful and useful for end-users, not the maintainer. It's a worse experience for the end-user, doesn't actually save the maintainer any time, and really the only benefit is that the port needs fewer changes if the name of the program suddenly changes, which occurs once every never. We are not the customer, nor is make(1). --=20 Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org --00000000000057d81c0643cdd54d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Nov 17, 2025 at 12:12=E2=80=AFPM Chris &= lt;i.h8.git@bsdforge.com> w= rote:
On 2025-11-15 12:21, Max Brazhniko= v wrote:
> On Sat, 15 Nov 2025 19:43:26 +0100 Zsolt Udvari wrote:
>> On Sat, Nov 15, 2025 at 09:16:30PM +0300, Max Brazhnikov wrote: >> > WWW also was a literal text when it just migrated to Makefile= . Why it should
>> > be obfuscated now? No difference for the make, but less conve= nient for humans:
>> > plain text url can be opened from the editor without running = the make.
>>
>> The github, gitlab and pear set a WWW (if it isn't defined in = Makefile) so
>> you can't open the url without running make. If you want see p= lain text
>> url should remove these definitions from Mk/bsd.sites.mk and
>
> I'm ok with this, framework may set WWW for ports, and ports can r= edefine it
> if needed. But if WWW is explicitly set in the Makefile it should be p= lain
> url.

If either is possible. Why should it not be what is easiest or most efficie= nt
for the
Maintainer/Developer at the time?

Because it should= be what is most helpful and useful for end-users, not the maintainer.

It&= #39;s a worse experience for the end-user, doesn't actually save the ma= intainer any time, and really the only benefit is that the port needs fewer= changes if the name of the program suddenly changes, which occurs once eve= ry never.

We are not the customer, nor is make(1).


--
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
--00000000000057d81c0643cdd54d--