From nobody Sun Nov 19 19:30:41 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SYLMj3l29z51DY5 for ; Sun, 19 Nov 2023 19:30:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SYLMj2Qwnz4Z52 for ; Sun, 19 Nov 2023 19:30:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700422241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1MUdJWvpVigkI5+fPv5Yiy/EgfYQyaR6pIlPefpM5bc=; b=irbDTtp0sdt/KM1+CBJ6YweWagljzqRKjhNIZKxj81fBwvLbQuiEZEij1z4GH1f47aE7P0 nOFnX/2YuTrQtw6FNxn4+uY9rJCXULfdmRermi3qAS4jMILV+5YLQX2nFvoOcfKX7r0sjW FhyXC4AevmXIplTt0uhtn4KkwJAB45j5FbfG8wYs6wMEyY7ao7aEs0iN1CSdiN4N8BAgd4 SVJjmL5fgRLBPCyBix3p4B5+1Dz69+VJ3gCIkSzD0KaQg9wIyBWDSLDh8tLZ+NGrtaOTJB DTv9msLDJr9TUseBW04xglx37B2HMHVZy0+xTeFcPpElr9HJ+BLBsuAgS1+ANA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700422241; a=rsa-sha256; cv=none; b=WY/PQUfEOFqPajVGzpRd51woihNCYwsgm0qqkdJLEIMhzoZYq2Xc+iqZaKGOHCaKchD1yL E3V1R1xYanpRbWlKxLHbX+I01qPA03G+qVGsJUD32IGmlpgsspFowOuM6XCPwdSm25lDjm 4pgZ6X3K9MBtAC7Z7hBzhy4ezA6/dAJNcPe2T5ylvm4/NW2w9BeYwBC/D+VmWi9cKEK2EN VvtMnHi7qpjvkyK9RkgMs8tx7O3vC0sqtDTm+LZx0Rfog5BWm5cI2mn5CB+0/zwAIZFELV V5D/YeARSt6QdTy/ALxmr2QJ73gJJTgid9P14YPxXIxkztTSBpg8wZ9muYOTrw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SYLMj0x76z722 for ; Sun, 19 Nov 2023 19:30:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AJJUfaJ078875 for ; Sun, 19 Nov 2023 19:30:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AJJUf9s078874 for net@FreeBSD.org; Sun, 19 Nov 2023 19:30:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 275001] if_wg: Missing radix unlock can cause deadlock Date: Sun, 19 Nov 2023 19:30:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275001 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D16c65f7ae15e6ca8b36fc546e038c5927= 0c87ccc commit 16c65f7ae15e6ca8b36fc546e038c59270c87ccc Author: Aaron LI AuthorDate: 2023-11-11 13:13:08 +0000 Commit: Kristof Provost CommitDate: 2023-11-19 19:29:35 +0000 if_wg: Missing radix unlock can cause deadlock In function 'wg_aip_add()', the error path of returning ENOMEM when (node =3D=3D NULL) is forgetting to unlock the radix tree, and thus may= lead to a deadlock. PR: 275001 Reviewed by: kp MFC after: 1 week (cherry picked from commit dcc4d2939f789a6d1f272ffeab2068ba2b7525ea) sys/dev/wg/if_wg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=