From owner-freebsd-net Tue Sep 3 11:40:32 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57EE337B400 for ; Tue, 3 Sep 2002 11:40:29 -0700 (PDT) Received: from iguana.icir.org (iguana.icir.org [192.150.187.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id F390D43E6E for ; Tue, 3 Sep 2002 11:40:28 -0700 (PDT) (envelope-from rizzo@iguana.icir.org) Received: from iguana.icir.org (localhost [127.0.0.1]) by iguana.icir.org (8.12.3/8.11.3) with ESMTP id g83IeSIb001722; Tue, 3 Sep 2002 11:40:28 -0700 (PDT) (envelope-from rizzo@iguana.icir.org) Received: (from rizzo@localhost) by iguana.icir.org (8.12.3/8.12.3/Submit) id g83IeSts001721; Tue, 3 Sep 2002 11:40:28 -0700 (PDT) (envelope-from rizzo) Date: Tue, 3 Sep 2002 11:40:28 -0700 From: Luigi Rizzo To: "Kenneth D. Merry" Cc: Charles Sprickman , freebsd-net@FreeBSD.ORG Subject: Re: fxp and 802.3 flow control Message-ID: <20020903114028.B1595@iguana.icir.org> References: <20020903123508.A95635@panzer.kdm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020903123508.A95635@panzer.kdm.org>; from ken@kdm.org on Tue, Sep 03, 2002 at 12:35:08PM -0600 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org i wouldn't call the thing a "problem" -- flow control packets are a feature which you can enable or disable. I have used something similar to your patch below, and noticed that just setting tx_fc_dis=1 (check the comment, btw) makes these frames disappear, i suppose that setting the bit causes some negotiation with the peer that disables their generation on both sides. cheers luigi On Tue, Sep 03, 2002 at 12:35:08PM -0600, Kenneth D. Merry wrote: ... > > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=172663+0+archive/2000/freebsd-net/20000220.freebsd-net > > > > And wondering the same thing... Don't see anything in the fxp manpage > > about this, was Ken's patch included at some point? Is his explanation on > > target? > > The problem is still there. I've got a local patch in my tree to take care > of it. > > Jonathan Lemon did some things to attempt to make it better, but they > didn't fix the problem for me. I've attached a patch against -current that > fixes it for me with the new fxp driver. (The patch in the message above > is against the old fxp driver.) > > Ken > -- > Kenneth Merry > ken@kdm.org > --- //depot/FreeBSD-current/src/sys/dev/fxp/if_fxp.c 2002/08/19 15:56:44 > +++ //depot/FreeBSD-ken/src/sys/dev/fxp/if_fxp.c 2002/08/20 13:59:13 > @@ -1696,10 +1696,10 @@ > cbp->fc_delay_lsb = 0x1f; > cbp->fc_delay_msb = 0x01; > cbp->pri_fc_thresh = 3; > - cbp->tx_fc_dis = 0; /* enable transmit FC */ > + cbp->tx_fc_dis = 1; /* enable transmit FC */ > cbp->rx_fc_restop = 1; /* enable FC restop frames */ > cbp->rx_fc_restart = 1; /* enable FC restart frames */ > - cbp->fc_filter = !prm; /* drop FC frames to host */ > + cbp->fc_filter = 1; /* drop FC frames to host */ > cbp->pri_fc_loc = 1; /* FC pri location (byte31) */ > } > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message