Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Apr 2012 10:59:11 +0400
From:      Sergey Kandaurov <pluknet@freebsd.org>
To:        Jeremie Le Hen <jeremie@le-hen.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r233296 - head/lib/libc/gen
Message-ID:  <CAE-mSOJ06vNggYRm_VARdSBVD-2Dkutn5GAocRaYig-CS93pmA@mail.gmail.com>
In-Reply-To: <20120414113132.GA71196@felucia.tataz.chchile.org>
References:  <201203220942.q2M9gSvv017339@svn.freebsd.org> <20120414113132.GA71196@felucia.tataz.chchile.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 14 April 2012 15:31, Jeremie Le Hen <jeremie@le-hen.org> wrote:
> Hi Sergey,
>
> On Thu, Mar 22, 2012 at 09:42:28AM +0000, Sergey Kandaurov wrote:
>> Author: pluknet
>> Date: Thu Mar 22 09:42:27 2012
>> New Revision: 233296
>> URL: http://svn.freebsd.org/changeset/base/233296
>>
>> Log:
>> =A0 Prevent fs_file NULL pointer dereference in fixfsfile() uncovered af=
ter r1.5
>> =A0 when passing damaged user-supplied fstab file data.
>>
>> =A0 MFC after: =A01 week
>>
>> Modified:
>> =A0 head/lib/libc/gen/fstab.c
>>
>> Modified: head/lib/libc/gen/fstab.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/lib/libc/gen/fstab.c Thu Mar 22 09:29:07 2012 =A0 =A0 =A0 =A0(r=
233295)
>> +++ head/lib/libc/gen/fstab.c Thu Mar 22 09:42:27 2012 =A0 =A0 =A0 =A0(r=
233296)
>> @@ -91,7 +91,7 @@ fixfsfile()
>> =A0 =A0 =A0 struct stat sb;
>> =A0 =A0 =A0 struct statfs sf;
>>
>> - =A0 =A0 if (strcmp(_fs_fstab.fs_file, "/") !=3D 0)
>> + =A0 =A0 if (_fs_fstab.fs_file !=3D NULL &&strcmp(_fs_fstab.fs_file, "/=
") !=3D 0)
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 return;
>> =A0 =A0 =A0 if (statfs("/", &sf) !=3D 0)
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 return;
>
> Would you mind MFC'ing this please? =A0It bit me today :).
>
> Thanks.

Ah, sure. I will today.
[I was AFK for some time, and now I'm here again.]

--=20
wbr,
pluknet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOJ06vNggYRm_VARdSBVD-2Dkutn5GAocRaYig-CS93pmA>