From owner-cvs-src@FreeBSD.ORG Fri Aug 8 22:37:54 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D90F71065677 for ; Fri, 8 Aug 2008 22:37:54 +0000 (UTC) (envelope-from peter@wemm.org) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.175]) by mx1.freebsd.org (Postfix) with ESMTP id B14A38FC0C for ; Fri, 8 Aug 2008 22:37:54 +0000 (UTC) (envelope-from peter@wemm.org) Received: by wf-out-1314.google.com with SMTP id 24so931670wfg.7 for ; Fri, 08 Aug 2008 15:37:54 -0700 (PDT) Received: by 10.142.157.15 with SMTP id f15mr1127203wfe.291.1218235074186; Fri, 08 Aug 2008 15:37:54 -0700 (PDT) Received: by 10.142.76.14 with HTTP; Fri, 8 Aug 2008 15:37:54 -0700 (PDT) Message-ID: Date: Fri, 8 Aug 2008 15:37:54 -0700 From: "Peter Wemm" To: "Stanislav Sedov" In-Reply-To: <20080809020838.d63be5da.stas@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200808081631.m78GVG9i088754@repoman.freebsd.org> <200808081427.42536.jhb@freebsd.org> <20080808185133.GG97161@deviant.kiev.zoral.com.ua> <200808081459.54735.jhb@freebsd.org> <20080809020838.d63be5da.stas@FreeBSD.org> Cc: Kostik Belousov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/share/man/man4 Makefile cpuctl.4 src/sys/amd64/amd64 support.S src/sys/amd64/conf NOTES src/sys/amd64/include cpufunc.h specialreg.h src/sys/conf files.amd64 files.i386 src/sys/dev/cpuctl cpuctl.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Aug 2008 22:37:54 -0000 On Fri, Aug 8, 2008 at 3:08 PM, Stanislav Sedov wrote: > On Fri, 8 Aug 2008 14:02:19 -0700 > "Peter Wemm" mentioned: > >> >> I just don't think it is particularly useful to add a restriction / >> priv check for information that is available in an unprivileged >> fashion by other means. I think the priv check should go away since >> it doesn't achieve anything. >> > > Yeah, that's why cpuctl(4) has priv checks only for wrmsr and update > features. Using this checks one can control how much to grant to the > root user. Serves me right for responding to what I thought I read vs actually reading the code then.. :) -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV "All of this is for nothing if we don't go to the stars" - JMS/B5 "If Java had true garbage collection, most programs would delete themselves upon execution." -- Robert Sewell