From owner-freebsd-hackers Fri May 10 18:53:31 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from ns2.gnf.org (ns2.gnf.org [63.196.132.68]) by hub.freebsd.org (Postfix) with ESMTP id D7F4B37B401 for ; Fri, 10 May 2002 18:53:25 -0700 (PDT) Received: from mail.gnf.org (smtp.gnf.org [172.25.11.11]) by ns2.gnf.org (8.11.6/8.11.6) with ESMTP id g4B1heO14119; Fri, 10 May 2002 18:43:45 -0700 (PDT) (envelope-from gordont@gnf.org) Received: by mail.gnf.org (Postfix, from userid 888) id 4376611E511; Fri, 10 May 2002 18:53:20 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.gnf.org (Postfix) with ESMTP id 41BDB11A572; Fri, 10 May 2002 18:53:20 -0700 (PDT) Date: Fri, 10 May 2002 18:53:20 -0700 (PDT) From: Gordon Tetlow To: Terry Lambert Cc: hackers@freebsd.org Subject: Re: nextboot loader diff In-Reply-To: <3CDC450D.20F05776@mindspring.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 10 May 2002, Terry Lambert wrote: > Gordon Tetlow wrote: > > Is there anything that is wrong with the conceptual implementation of the > > nextboot loader code that I've submitted? It definitely needs a code > > cleanup on the forth side (which I'm not qualified to do), but if there > > are no other objections, I'd really like to see this code committed. > > There should be a list, so that in a brown-out or whatever, you > don't end up toggling back to the previous version accidently. This is not something that is meant for you to massage which root partition you are going to boot up off of. > You should only ever rewrite the contents of a single file, and > it shouldn't be an important file. Yes, that's exactly what my patch does. > The existance/non-existance of the single file should be enough > to trigger/suppress the nextboot behaviour. I can't unlink files in the loader, so the presence of such a file wouldn't help. > Don't assume that the nextboot file will be on the same disk and/or > partition as the boot and other config file code. Well, I'm assuming it's on the root partition. It would be kinda silly for it to anywhere else. > Together, these things will allow the new code to solve the same > problem that the old code solved on the InterJet. I've never heard nor seen the old code. I don't know what it did, and I don't particularly care. I did this because I thought the way Wes Peters did his implementation was rather hackish (not saying mine is any better =) and suboptimal if the machine doesn't make it to multi-user. Please refer to the commit logs from earlier this month if you don't know of the commit I'm referring to. -gordon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message