From owner-svn-src-head@freebsd.org Mon Oct 8 16:46:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16B5210C4812; Mon, 8 Oct 2018 16:46:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B54B571E9C; Mon, 8 Oct 2018 16:46:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 4C9A910B4CE; Mon, 8 Oct 2018 12:46:52 -0400 (EDT) Subject: Re: svn commit: r264378 - head/sys/geom/part To: Marcel Moolenaar , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201404122028.s3CKSdo1026394@svn.freebsd.org> Cc: Josh Paetzel From: John Baldwin Message-ID: Date: Mon, 8 Oct 2018 09:46:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201404122028.s3CKSdo1026394@svn.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 08 Oct 2018 12:46:53 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 16:46:55 -0000 On 4/12/14 1:28 PM, Marcel Moolenaar wrote: > Author: marcel > Date: Sat Apr 12 20:28:39 2014 > New Revision: 264378 > URL: http://svnweb.freebsd.org/changeset/base/264378 > > Log: > Align and round the partitionable disk space to 4K by default. > Since this would also apply when recovering, make sure not to > align or round when that would have a partition fall outside > the partitionable area. This needs a way to be overridden. If you have a machine installed with a layout created prior to this change (e.g. a zpool mirror or RAID or some other mirror or RAID), you can no longer create a matching partition since the starting sector is now always 40 instead of 34 and the partition size won't match. Also, while we may want to create sane layouts by default, we should probably always provide a way to create less-sane layouts that are still conformant to the spec. I do wonder if this kind of default preference shouldn't belong in the userspace gpart tool rather than the kernel and the kernel should create any compliant layout as requested by userland instead. jpaetzel@ just ran into this case where he can't replace a failed disk in a system running 12 that was first formatted on 10, so it's not academic. -- John Baldwin