From owner-svn-src-all@freebsd.org Mon Nov 11 22:12:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CFADF1BFBF3; Mon, 11 Nov 2019 22:12:30 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47BlVQ56hfz3FrJ; Mon, 11 Nov 2019 22:12:30 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm1-x343.google.com with SMTP id a17so885275wmb.0; Mon, 11 Nov 2019 14:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=FkoGT9EUOfElAMOvQBaacrRPtvKb0up1asKh4dpvGTQ=; b=CkSx508+fcX5fiXCG0KUMc6fEDe7z9xjRvw9DoehVSYniOicgZVAPamgM4FuOL5p19 jFtrEpNlalotMzap0sonuRep0zPuY1rmR7vt2Xg0YoSEZsIGU01tfgU8GgFBfNjXWanN 6l4J5tqETFQwSVLz8j5lh1j/saF8NLuy6A4J6nBbmC05R658CUxyms5V9YFBz9mDbCL3 nwxZmtOcuaru83KNHum2Q+jTKp7++i3SmmiF7pUcNkiFdR1qMUHoSHqEKslT6ODiap2c R0tR44hvd0Axj0JlD9LrGfLjz3VnoWByi06ByeDzOvnrw1XBm8aOQM7qBtBEgdvQ4D96 pn/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=FkoGT9EUOfElAMOvQBaacrRPtvKb0up1asKh4dpvGTQ=; b=XVBMQz8eSAFWz6u1SCA1X64dLWiR1Ecgk4TeG1iqVZGGB7Wa7q1yw8OK2KROynIXy8 aR1Nr91flyBbKvy5lmFSKQ4UH1IYno0zmuxkzCb39/LrvQqPPZCkc2BYOOZuFZWGgtry Iyo57K++V+PVeGgMlvtkUgFSAp1RfFgdzhAqh+oheUT5EKkOfizn4CaaOuAMHr50n0vP SRdVYwknsRUkyj5xzyXrFVMi6C96GMXKzrDK+4ya9NoRlgpVIFhkTZZkWMQt4JTllGt8 v3BCk08tuxatu0NXZABnAYWHFNBawZJzFpkFHNGXPD/tnaj5F76AuYGaFN5NgKP7WAw/ Ggqw== X-Gm-Message-State: APjAAAXEKfZTFrsEN4oScO7mQb6+oVEj8ZQnKo8tifnyCv8+/xvSYrYu 02YvWA2zHI9txRAOFPFPsOo8tlQe X-Google-Smtp-Source: APXvYqxOSij/wU6z/QPNEXyxH3wpKkgV+59Bm8Cur5mTFNzxnqyP63ngjZZgNJ0qseiaBEOd9m5IYw== X-Received: by 2002:a1c:1b8f:: with SMTP id b137mr995586wmb.5.1573510349042; Mon, 11 Nov 2019 14:12:29 -0800 (PST) Received: from brick (cpc92302-cmbg19-2-0-cust461.5-4.cable.virginm.net. [82.1.209.206]) by smtp.gmail.com with ESMTPSA id k125sm1680469wmf.2.2019.11.11.14.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 14:12:28 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Mon, 11 Nov 2019 22:12:26 +0000 From: Edward Tomasz Napierala To: Ian Lepore Cc: Alexander Leidinger , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354458 - head/libexec/rc/rc.d Message-ID: <20191111221226.GB1111@brick> Mail-Followup-To: Ian Lepore , Alexander Leidinger , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201911071815.xA7IFOhI070066@repo.freebsd.org> <20191109204958.Horde.B0ynnS_aur1OZimnDNObsAt@webmail.leidinger.net> <20191110160819.GA1095@brick> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47BlVQ56hfz3FrJ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.98 / 15.00]; NEURAL_HAM_MEDIUM(-0.98)[-0.984,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Nov 2019 22:12:30 -0000 On 1111T1349, Ian Lepore wrote: > On Sun, 2019-11-10 at 16:08 +0000, Edward Tomasz Napierala wrote: > > On 1109T2049, Alexander Leidinger wrote: > > > Quoting Edward Tomasz Napierala (from Thu, 7 > > > Nov > > > 2019 18:15:24 +0000 (UTC)): > > > > > > > Author: trasz > > > > Date: Thu Nov 7 18:15:24 2019 > > > > New Revision: 354458 > > > > URL: https://svnweb.freebsd.org/changeset/base/354458 > > > > > > > > Log: > > > > Extend the linux rc script to mount the neccessary file > > > > systems, > > > > set ELF fallback brand, and load pty(4). > > > > > > We never did something like that. We have it documented > > > everywhere > > > that it needs to be done manually. So this is at least a POLA > > > violation. It is great that the nocover option is used in the > > > mount, > > > but it's still some kind of layering violation (I may want to > > > have > > > only a subset mounted, or nothing at all). > > > > It is kind of a POLA violation, but previously the linux_enable > > knob didn't do much apart from loading the linux{,64}.ko kernel > > module and doing something weird with ldconfig, which I'm not > > even sure is actually useful. In other words, the old behaviour > > can be restored by just not using linux_enable, and instead > > loading the kernel modules the same way all the others are loaded. > > > > Could you give me some use case why someone would want only a subset > > of the filesystems? > > > > Well, there's my use case, where the subset of those filesystems that I > want mounted is: none of them. > > The apps I use under the linuxlator work fine without having a single > one of those filesystems mounted, and I don't want something to start > mounting them for me when I don't even need them. Thanks, makes sense. See https://reviews.freebsd.org/D22320; I've added both you and Alexander as reviewers.