From owner-freebsd-current@FreeBSD.ORG Fri Mar 9 19:29:59 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 95F90106566C; Fri, 9 Mar 2012 19:29:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 6855C8FC14; Fri, 9 Mar 2012 19:29:59 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id EDEBD46B2A; Fri, 9 Mar 2012 14:29:52 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3E743B926; Fri, 9 Mar 2012 14:29:52 -0500 (EST) From: John Baldwin To: Dimitry Andric Date: Fri, 9 Mar 2012 10:13:23 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <4F594BF4.9060802@FreeBSD.org> In-Reply-To: <4F594BF4.9060802@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201203091013.24174.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 09 Mar 2012 14:29:52 -0500 (EST) Cc: freebsd-current@freebsd.org, Jung-uk Kim , Jia-Shiun Li Subject: Re: boot2 overflow when building with clang X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2012 19:29:59 -0000 On Thursday, March 08, 2012 7:16:52 pm Dimitry Andric wrote: > On 2012-03-07 05:51, Jia-Shiun Li wrote: > > I am not familiar with boot2, but it looks like allocated size for > > boot2 is not enough to hold code generated by clang. Reverting r232570 > > fixes it. > > Please test the attached diff. Since it modifies bsd.sys.mk, either run > "make install" in share/mk, or use "make buildenv" before rebuilding > sys/boot/i386/boot2. > > It would also be nice if you could test the actual installation of the > bootstrap, and its proper operation. However, be sure to have some way > of recovering the first 16 sectors of your disk before you do so. :) The changes to boot2.c are all bugs unfortunately. boot2's bss is not zero'd. -- John Baldwin