From owner-freebsd-ports@FreeBSD.ORG Fri Jun 25 22:15:39 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52D1D106566C for ; Fri, 25 Jun 2010 22:15:39 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id D754A8FC18 for ; Fri, 25 Jun 2010 22:15:38 +0000 (UTC) Received: by wyf22 with SMTP id 22so1763543wyf.13 for ; Fri, 25 Jun 2010 15:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=MhKey3snRG+ekYn6UzwCv4G6iBw91HYXN1a4eJgz7/U=; b=OExh0TdP8jzeQFU5ykCa/1HV0fzl1mdk4K4DSQ44k/HpkQaL2NbeUgX2RFF60HJG8I UjMmJs1Kg8scfGaeYwjI9KxuSuFq5Z8b23cQTQ6di+4+xubaM/5cr0p/NSHqf7kJpWq9 1VMXOIW3lou3s3EGXdHN2EocZcc8YqaRDlKj0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=wud+YYgwci02XiHxqRFyxO3G7CTIyx/uRWjplWAweGLA05gKLs9JoQKgA1Z/2naFqV mlNS8Z1p5KgAk74BDgVXz8WH3QZ9fP/tczmIrCc7QC0oMGcgaunisnvMlrDX6xkNH4ZM FtayQ5wcMB4pGZKWXG6ZOiBLWVQb5tHNkBJaM= Received: by 10.216.88.147 with SMTP id a19mr994409wef.93.1277504137758; Fri, 25 Jun 2010 15:15:37 -0700 (PDT) Received: from localhost ([78.142.140.194]) by mx.google.com with ESMTPS id u81sm1124457wei.28.2010.06.25.15.15.32 (version=SSLv3 cipher=RC4-MD5); Fri, 25 Jun 2010 15:15:36 -0700 (PDT) From: Anonymous To: David Naylor References: <201006251808.29467.naylor.b.david@gmail.com> <201006252334.32957.naylor.b.david@gmail.com> Date: Sat, 26 Jun 2010 02:15:16 +0400 In-Reply-To: <201006252334.32957.naylor.b.david@gmail.com> (David Naylor's message of "Fri, 25 Jun 2010 23:34:28 +0200") Message-ID: <86bpayoj2j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS and openjdk6 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2010 22:15:39 -0000 David Naylor writes: > On Friday 25 June 2010 18:08:22 David Naylor wrote: >> Hi, >> >> java/openjdk6 breaks with FORCE_MAKE_JOBS (it implements its own think). >> The attached patch fixes openjdk6, marks it as MAKE_JOBS_SAFE and makes it >> respect MAKE_JOBS_NUMBER. >> >> Regards, >> >> David >> >> P.S. I'm off list > > Oops. My hack didn't work. > > With MAKE_JOBS_SAFE _MAKE_JOBS is included but that evaluated to -jN and this > is choking the Makefile. Is there an easier way to exclude _MAKE_JOBS? > Perhaps set _MAKE_JOBS conditionally in bsd.ports.mk and a port can then do > _MAKE_JOBS="" Smth like %% Index: Mk/bsd.port.mk @@ -2292,7 +2292,7 @@ _MAKE_JOBS= # .else .if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS) MAKE_JOBS_NUMBER?= `${SYSCTL} -n kern.smp.cpus` -_MAKE_JOBS= -j${MAKE_JOBS_NUMBER} +_MAKE_JOBS?= -j${MAKE_JOBS_NUMBER} .if defined(FORCE_MAKE_JOBS) && !defined(MAKE_JOBS_SAFE) BUILD_FAIL_MESSAGE+= "You have chosen to use multiple make jobs (parallelization) for all ports. This port was not tested for this setting. Please remove FORCE_MAKE_JOBS and retry the build before reporting the failure to the maintainer." .endif %% > > The attached patch fixes the above problem without touching bsd.ports.mk. > You can as well define empty _MAKE_JOBS *after* . At least it wouldn't be as ugly as redefining do-build target. %% Index: java/openjdk6/Makefile @@ -266,3 +267,6 @@ post-install: @${CAT} ${PKGMESSAGE} .include + +# XXX: use `?=' in bsd.port.mk +_MAKE_JOBS= %% > Regards