From owner-cvs-all  Tue Nov 27  9:56:22 2001
Delivered-To: cvs-all@freebsd.org
Received: from silby.com (cb34181-a.mdsn1.wi.home.com [24.14.173.39])
	by hub.freebsd.org (Postfix) with ESMTP id D151337B41C
	for <cvs-all@FreeBSD.org>; Tue, 27 Nov 2001 09:55:54 -0800 (PST)
Received: (qmail 68517 invoked by uid 1000); 27 Nov 2001 17:55:53 -0000
Received: from localhost (sendmail-bs@127.0.0.1)
  by localhost with SMTP; 27 Nov 2001 17:55:53 -0000
Date: Tue, 27 Nov 2001 11:55:53 -0600 (CST)
From: Mike Silbersack <silby@silby.com>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: Brian Somers <brian@freebsd-services.com>,
	Robert Watson <rwatson@FreeBSD.org>,
	Gregory Neil Shapiro <gshapiro@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/etc security
In-Reply-To: <xzpvgfwdrvc.fsf@flood.ping.uio.no>
Message-ID: <20011127115346.R39566-100000@achilles.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 27 Nov 2001, Dag-Erling Smorgrav wrote:

> Mike Silbersack <silby@silby.com> writes:
> > +			    mail -s '$host security check output' $daily_status_security_output;;
>
> Variables aren't expanded inside single-quoted strings.  Use double
> quotes.
>
> DES
> --
> Dag-Erling Smorgrav - des@ofug.org

Yep, that does the trick.  At this rate, I may eventually learn shell
scripting. :)

Here's the revised patch, I'll go ahead and commit it in a few hours
unless there are further problems found.

Mike "Silby" Silbersack

--- /usr/src/etc/security	Tue Nov 27 11:08:21 2001
+++ /etc/security	Tue Nov 27 11:13:35 2001
@@ -58,8 +58,6 @@
 yesterday=`date -v-1d "+%b %e "`

 host=`hostname`
-[ $sflag = FALSE ] && echo "To: root@${host}"
-[ $sflag = FALSE ] && echo "Subject: ${host} security check output"

 umask 027

--- /usr/src/etc/periodic/daily/450.status-security	Wed Jun  6 14:24:44 2001
+++ /etc/periodic/daily/450.status-security	Tue Nov 27 11:55:00 2001
@@ -36,8 +36,10 @@
 			    >$daily_status_security_output 2>&1;;
 		    *)
 			echo "    (output mailed separately)"
+			host=`hostname`
+			export host
 			sh /etc/security $args 2>&1 |
-			    sendmail $daily_status_security_output;;
+			    mail -s "$host security check output" $daily_status_security_output;;
 		esac;;
 	esac;;



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message