From nobody Wed Apr 22 14:16:53 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g11WB1NRPz6Zd8c for ; Wed, 22 Apr 2026 14:16:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g11W94j3Yz3fFL for ; Wed, 22 Apr 2026 14:16:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776867413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+P9mQXPTxWH93aaU5D77FAMXz3OsqFovSoXM+BvfiPM=; b=G+GLaINUYS0FEb9qjfIT7n51txhsQEdh9AASObL7pGDDcGitZx2kScT3FJFaKEMtBp4XtQ eO0Qxk6g5HAC/wQQQve4M1A3BA70zVGgfhqzB27uSiFyOBl13FRrsxG/4dSwNheWl+xHuW b6jZFiIr/HwHfTHluEQOEHHwePjwNR1hcz4jIc88qOFa9xWFmFDwDJQimsTJ44MIO58ydO SnO7bPwmqwb+g6cNzEFC0tbLp3dsx6ZfMVSg3mhG0gSBsgg+Ft5rjFh3NOKoVhmOWhkfwl 8j/40+Cli/IAQeEt8qL7SzAspFsN2f3i6MONETBDNldswQuML0ToBt3vF7h1cg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776867413; a=rsa-sha256; cv=none; b=sPxVAF3hJo9ZTh1iVzA/wk4HQNmH0L5vUVIB2rBjfOHmw3qFF1zYmNwuwQV43Jk9PiQ645 VrF/e+6DLwWPzJgFwO9fqE2/YS2anIgoDghWFF9dZFWLvL3EGzCUVDDftwsRs4lEWLrT2x 1K/MZyylP3pfSS1KdDSH3PI5XUKR534hLguJpqAZ/f+XryOhLLL7iBJU3rT/jRmbcAryke oP8jcHzsiEkErpZnS8qFaouiCTBRL0kRh8+QFM9Qfzjvre3Z2LklcqiIQzAlE8Gp0bXefw 1hEawGM8Qb8qwwOjx9JmoLkIbKI6aASlQuvliGFCOtq9A8pKW4wNwj9VBmBHKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776867413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+P9mQXPTxWH93aaU5D77FAMXz3OsqFovSoXM+BvfiPM=; b=AYa0FTyxsg1i2Dl2I/A0EyUPdRm+EgwDfWsgIszWdCoBk8v8g9wib9RNnUzb4CemfhNJFg 31HL9SUjFlmUsA3/yMXJE5qhC1kvN5cFsRf/cFaGFq9QMG5yTp7XQ6Vi3pf6Wh5lEq8g67 XNTfK/11/zKDTq4As9ehNLxMfjVK9bBQD1RLP+U+tRtR+BvqtLa+aCzi7olcYHfB04w0QA So40XR8cDnbKXHWtEpgRlYPTfTNJmBaJ983BWBiDX/sqwiGunMcjNv5H4PAxplIG94Xrme IUpST2DhW2jCoRG2OHvPHG5sLZnNAwc6WTOe3W8aPr5m584yW0IW/8uKTFlocA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g11W94J5QzYtt for ; Wed, 22 Apr 2026 14:16:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25982 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Apr 2026 14:16:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Cochard Subject: git: 19213b8eb33f - main - ctl: require ctladm in addition to sg_opcodes List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olivier X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 19213b8eb33f8cb692abb1ee857778af347ddfeb Auto-Submitted: auto-generated Date: Wed, 22 Apr 2026 14:16:53 +0000 Message-Id: <69e8d855.25982.19cab126@gitrepo.freebsd.org> The branch main has been updated by olivier: URL: https://cgit.FreeBSD.org/src/commit/?id=19213b8eb33f8cb692abb1ee857778af347ddfeb commit 19213b8eb33f8cb692abb1ee857778af347ddfeb Author: Olivier Cochard AuthorDate: 2026-04-22 14:14:04 +0000 Commit: Olivier Cochard CommitDate: 2026-04-22 14:16:15 +0000 ctl: require ctladm in addition to sg_opcodes Each test case in opcodes.sh uses ctladm to create and remove the LUN it exercises, but only sg_opcodes was listed in require.progs. On systems where ctladm is not builded the tests would fail at setup instead of being skipped cleanly. Approved by: asomers Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D56568 --- tests/sys/cam/ctl/opcodes.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/sys/cam/ctl/opcodes.sh b/tests/sys/cam/ctl/opcodes.sh index 1d558a1095a0..ccb39828f6ed 100644 --- a/tests/sys/cam/ctl/opcodes.sh +++ b/tests/sys/cam/ctl/opcodes.sh @@ -46,7 +46,7 @@ all_opcodes_head() { atf_set "descr" "REPORT SUPPORTED OPCODES can report all supported opcodes" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } all_opcodes_body() { @@ -66,7 +66,7 @@ basic_head() { atf_set "descr" "REPORT SUPPORTED OPCODES can report a single supported opcode" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } basic_body() { @@ -84,7 +84,7 @@ invalid_rep_opts_head() { atf_set "descr" "REPORT SUPPORTED OPCODES will fail gracefully if the REPORTING OPTIONS field is set to an invalid value" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } invalid_rep_opts_body() { @@ -105,7 +105,7 @@ missing_service_action_head() { atf_set "descr" "REPORT SUPPORTED OPCODES fails gracefully if the service action is omitted" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } missing_service_action_body() { @@ -124,7 +124,7 @@ out_of_bounds_service_action_head() { atf_set "descr" "REPORT SUPPORTED OPCODES fails gracefully if the requested service action is out of bounds" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } out_of_bounds_service_action_body() { @@ -152,7 +152,7 @@ service_action_head() { atf_set "descr" "REPORT SUPPORTED OPCODES can query an opcode that needs a service action" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } service_action_body() { @@ -172,7 +172,7 @@ unexpected_service_action_head() { atf_set "descr" "REPORT SUPPORTED OPCODES fails gracefully if an extraneous service action is provided" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } unexpected_service_action_body() { @@ -194,7 +194,7 @@ unexpected_service_action_ro3_head() { atf_set "descr" "REPORT SUPPORTED OPCODES fails gracefully if an extraneous service action is provided, using REPORTING OPTIONS 3" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } unexpected_service_action_ro3_body() { @@ -213,7 +213,7 @@ unsupported_opcode_head() { atf_set "descr" "REPORT SUPPORTED OPCODES can report a single unsupported opcode" atf_set "require.user" "root" - atf_set "require.progs" sg_opcodes + atf_set "require.progs" sg_opcodes ctladm } unsupported_opcode_body() {