From owner-freebsd-toolchain@FreeBSD.ORG Mon Oct 17 17:42:13 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37AF7106564A for ; Mon, 17 Oct 2011 17:42:13 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id DBA168FC0C for ; Mon, 17 Oct 2011 17:42:12 +0000 (UTC) Received: from [10.30.101.53] ([209.117.142.2]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p9HHds8W089698 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Mon, 17 Oct 2011 11:39:55 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Mon, 17 Oct 2011 11:39:39 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <12466AAB-625F-4D20-80E6-2D4235ED81EC@bsdimp.com> References: <20111017152548.GA66978@freebsd.org> To: Gerald Pfeifer X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Mon, 17 Oct 2011 11:39:55 -0600 (MDT) Cc: freebsd-toolchain@freebsd.org Subject: Re: [toolchain] disable -Wtautological-compare for clang X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2011 17:42:13 -0000 I'm all for leaving it on because things like char are signed on some = architectures and unsigned on others. This leads to bugs that only = appear on one architecture. This warning will, at least, flag those = usages. On Oct 17, 2011, at 10:56 AM, Gerald Pfeifer wrote: > On Mon, 17 Oct 2011, Alexander Best wrote: >> any chance we could disable -Wtautological-compare for clang? i don't=20= >> think comparing an unsigned int against < 0 is worth a warning. = actually=20 >> it's always nice to have such a seatbelt, in case somebody changes = the=20 >> type to int and forgets to introduce such a check. >=20 > I am on the fence on this one, for when I used the equivalent warning > in GCC this did found a number of real issues that I then addressed = for > Wine (as an example). >=20 > Gerald > _______________________________________________ > freebsd-toolchain@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to = "freebsd-toolchain-unsubscribe@freebsd.org" >=20 >=20