Date: Sat, 13 Jul 2024 14:04:48 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, "arrowd@FreeBSD.org" <arrowd@FreeBSD.org> Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> In-Reply-To: <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1720872288_c5894cfe66e9a9dd9fa67c9e1e890b3a_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold <mat@freebsd.org> wrote:= >=C2=A0On=C2=A0Sat,=C2=A0Jul=C2=A013,=C2=A02024=C2=A0at=C2=A006:11:04= AM=C2=A0GMT,=C2=A0Daniel=C2=A0Engberg=C2=A0wrote: >>=C2=A0=C2=A0Hi, >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0This=C2=A0changes=C2=A0so=C2=A0LTO=C2= =A0option=C2=A0is=C2=A0no=C2=A0longer=C2=A0applied=C2=A0to=C2=A0Rust=C2= =A0(cargo) >>=C2=A0=C2=A0ports >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0BY= =C2=A0DEFAULT=C2=A0causing=C2=A0a=C2=A0regresssion,=C2=A0please=C2=A0fix.= >=C2=A0 >=C2=A0As=C2=A0it=C2=A0has=C2=A0been=C2=A0three=C2=A0months,= =C2=A0nobody=C2=A0complained=C2=A0something=C2=A0was=C2=A0broken >=C2= =A0so, >=C2=A0 >=C2=A0I=C2=A0don't=C2=A0think=C2=A0anything=C2=A0is= =C2=A0actually=C2=A0broken. >=C2=A0 >=C2=A0LTO=C2=A0as=C2=A0are=C2= =A0a=C2=A0few=C2=A0other=C2=A0features=C2=A0like=C2=A0SSP=C2=A0are=C2=A0use= r=C2=A0facing=C2=A0features, >=C2=A0not=C2=A0a >=C2=A0 >=C2=A0porters= =C2=A0facing=C2=A0options,=C2=A0it=C2=A0means,=C2=A0it's=C2=A0up=C2=A0to= =C2=A0the=C2=A0person=C2=A0doing=C2=A0the >=C2=A0 >=C2=A0building=C2= =A0to=C2=A0choose=C2=A0wether=C2=A0to=C2=A0enable=C2=A0it=C2=A0or=C2=A0not,= =C2=A0it=C2=A0is=C2=A0**not**=C2=A0up=C2=A0to >=C2=A0the >=C2=A0 >= =C2=A0person=C2=A0porting=C2=A0the=C2=A0software=C2=A0to=C2=A0forcefully= =C2=A0enable=C2=A0it. >=C2=A0 >=C2=A0--=C2=A0 >=C2=A0 >=C2=A0Mathie= u=C2=A0Arnold Hi, Likely because this pretty much silently went b= y because it was posted on Phab and you only CCed bapt. It's been enabled= since Jan 2023 (https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?i= d=3D967022fd812cf67dec264ee4e53bd016b69e7a2b) and tested/discussed here h= ttps://reviews.freebsd.org/D36736 before being enabled/committed. I notic= ed it now while updating a Rust (cargo-based) port. Best regards, = Daniel --_=_swift_1720872288_c5894cfe66e9a9dd9fa67c9e1e890b3a_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div>On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold <mat@f= reebsd.org> wrote:<br></div><div class=3D"ik_mail_quote answerContentMes= sage"><blockquote class=3D"ws-ng-quote"><pre style=3D"white-space: normal;"= ><div>On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote:<br></di= v><blockquote class=3D"ws-ng-quote"><div> Hi,<br></div><div> <br></div><di= v> This changes so LTO option is no longer applied to Rust (cargo) ports<br= ></div><div> BY DEFAULT causing a regresssion, please fix.<br></div></block= quote><div> <br></div><div>As it has been three months, nobody complained s= omething was broken so,<br></div><div>I don't think anything is actually br= oken.<br></div><div><br></div><div>LTO as are a few other features like SSP= are user facing features, not a<br></div><div>porters facing options, it m= eans, it's up to the person doing the<br></div><div>building to choose weth= er to enable it or not, it is **not** up to the<br></div><div>person portin= g the software to forcefully enable it.<br></div><div><br></div><div>-- <br= ></div><div>Mathieu Arnold<br></div></pre></blockquote></div><div>Hi,<br></= div><div><br></div><div>Likely because this pretty much silently went by be= cause it was posted on Phab and you only CCed bapt. It's been enabled since= Jan 2023 (<a href=3D"https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.m= k?id=3D967022fd812cf67dec264ee4e53bd016b69e7a2b">https://cgit.freebsd.org/p= orts/commit/Mk/Uses/cargo.mk?id=3D967022fd812cf67dec264ee4e53bd016b69e7a2b<= /a>) and tested/discussed here <a href=3D"https://reviews.freebsd.org/D3673= 6">https://reviews.freebsd.org/D36736</a>; before being enabled/committed. I= noticed it now while updating a Rust (cargo-based) port.<br></div><div><br= ></div><div>Best regards,<br></div><div>Daniel<br></div></body></html> --_=_swift_1720872288_c5894cfe66e9a9dd9fa67c9e1e890b3a_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?457bab3436f42fd12d80beb16e067cf0>