Date: Sat, 24 Oct 2009 13:05:41 +0200 From: Beat Gaetzi <beat@FreeBSD.org> To: Stanislav Sedov <stas@deglitch.com> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/emulators/virtualbox Makefile ports/emulators/virtualbox/files patch-configure Message-ID: <4AE2DF85.1090007@FreeBSD.org> In-Reply-To: <20091024143852.9be13dbe.stas@deglitch.com> References: <200910231429.n9NEToUC016266@repoman.freebsd.org> <20091024143852.9be13dbe.stas@deglitch.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Stanislav Sedov wrote:
> On Fri, 23 Oct 2009 14:29:50 +0000 (UTC)
> Beat Gaetzi <beat@FreeBSD.org> mentioned:
> \
>> | #
>> |
>> | PORTNAME= virtualbox
>> | @@ -76,6 +76,14 @@ KMK_BUILDTYPE= release
>> | KMK_CONFIG= VBOX_LIBPATH_X11=${LOCALBASE} VBOX_FREEBSD_SRC=${SRC_BASE}/sys
>> | KMK_FLAGS=
>> |
>> | +.if defined(WITHOUT_QT4) && !defined(WITHOUT_NLS)
>> | +BROKEN= NLS support requires QT4 frontend. Run 'make config' again!
>> | +.endif
>> | +
>> | +.if defined(WITHOUT_X11) && !defined(WITHOUT_QT4)
>> | +BROKEN= QT4 frontend requires X11 support. Run 'make config' again!
>> | +.endif
>> | +
>
> Why not enforce these required options instead?
Lets assume a user want to install virtualbox headless on a server. He
deselect X11 and QT4 support but accidentally select NLS support. If we
enfore the required options this means we will install all the X11 and
QT4 dependencies without asking on his server. With the current checks
the user could decide if he wants to deselect NLS support or add QT4 and
X11 support.
Beat
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AE2DF85.1090007>