From owner-cvs-ports@FreeBSD.ORG  Sat Oct 24 11:05:34 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4F84C10656B2;
	Sat, 24 Oct 2009 11:05:34 +0000 (UTC)
	(envelope-from beat@FreeBSD.org)
Received: from marvin.chruetertee.ch (marvin.chruetertee.ch [217.150.245.55])
	by mx1.freebsd.org (Postfix) with ESMTP id D4BCD8FC17;
	Sat, 24 Oct 2009 11:05:33 +0000 (UTC)
Received: from daedalus.network.local (107.47.62.81.cust.bluewin.ch
	[81.62.47.107] (may be forged)) (authenticated bits=0)
	by marvin.chruetertee.ch (8.14.3/8.14.3) with ESMTP id n9OB5SQR007202
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO);
	Sat, 24 Oct 2009 11:05:29 GMT (envelope-from beat@FreeBSD.org)
Message-ID: <4AE2DF85.1090007@FreeBSD.org>
Date: Sat, 24 Oct 2009 13:05:41 +0200
From: Beat Gaetzi <beat@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.23 (X11/20090821)
MIME-Version: 1.0
To: Stanislav Sedov <stas@deglitch.com>
References: <200910231429.n9NEToUC016266@repoman.freebsd.org>
	<20091024143852.9be13dbe.stas@deglitch.com>
In-Reply-To: <20091024143852.9be13dbe.stas@deglitch.com>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/emulators/virtualbox Makefile
 ports/emulators/virtualbox/files patch-configure
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Oct 2009 11:05:34 -0000

Stanislav Sedov wrote:
> On Fri, 23 Oct 2009 14:29:50 +0000 (UTC)
> Beat Gaetzi <beat@FreeBSD.org> mentioned:
> \
>> |  #
>> |  
>> |  PORTNAME=	virtualbox
>> | @@ -76,6 +76,14 @@ KMK_BUILDTYPE=	release
>> |  KMK_CONFIG=	VBOX_LIBPATH_X11=${LOCALBASE} VBOX_FREEBSD_SRC=${SRC_BASE}/sys
>> |  KMK_FLAGS=
>> |  
>> | +.if defined(WITHOUT_QT4) && !defined(WITHOUT_NLS)
>> | +BROKEN=		NLS support requires QT4 frontend. Run 'make config' again!
>> | +.endif
>> | +
>> | +.if defined(WITHOUT_X11) && !defined(WITHOUT_QT4)
>> | +BROKEN=		QT4 frontend requires X11 support. Run 'make config' again!
>> | +.endif
>> | +
> 
> Why not enforce these required options instead?

Lets assume a user want to install virtualbox headless on a server. He
deselect X11 and QT4 support but accidentally select NLS support. If we
enfore the required options this means we will install all the X11 and
QT4 dependencies without asking on his server. With the current checks
the user could decide if he wants to deselect NLS support or add QT4 and
X11 support.

Beat