From owner-svn-src-head@freebsd.org  Tue Apr 26 14:40:14 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DEFBB1C461;
 Tue, 26 Apr 2016 14:40:14 +0000 (UTC)
 (envelope-from rb743@hermes.cam.ac.uk)
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2679B10C1;
 Tue, 26 Apr 2016 14:40:13 +0000 (UTC)
 (envelope-from rb743@hermes.cam.ac.uk)
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/
Received: from xc1.bsdpad.com ([195.154.136.64]:23887)
 by ppsw-32.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587)
 with esmtpsa (LOGIN:rb743) (TLSv1:ECDHE-RSA-AES256-SHA:256)
 id 1av49s-000ZTB-08 (Exim 4.86_36-e07b163)
 (return-path <rb743@hermes.cam.ac.uk>); Tue, 26 Apr 2016 15:40:12 +0100
Date: Tue, 26 Apr 2016 15:24:55 +0100
From: Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r298580 - in head/sys/riscv: include riscv
Message-ID: <20160426142455.GA25801@bsdpad.com>
References: <201604251447.u3PElpfe084901@repo.freebsd.org>
 <20160425155044.GO2422@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160425155044.GO2422@kib.kiev.ua>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: "R. Bukin" <rb743@hermes.cam.ac.uk>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2016 14:40:14 -0000

On Mon, Apr 25, 2016 at 06:50:44PM +0300, Konstantin Belousov wrote:
> On Mon, Apr 25, 2016 at 02:47:51PM +0000, Ruslan Bukin wrote:
> > +/* An entry in the list of all pmaps */
> > +struct pmap_list_entry {
> > +	SLIST_ENTRY(pmap_list_entry) pmap_link;
> > +	struct pmap *pmap;
> > +};
> 
> This is weird. Why do you need separate structure to track the all
> pmaps list, instead of embedding the list link into pmap itself ? In
> particular, the pmap_list_entry.pmap pointing to the pmap looks strange.
> 
> And why do you use single-linked list for the container where you need
> to remove elements ?  The cost is the iteration over the whole container
> on removal, vs. additional pointer in each pmap.
> 

Many thanks. I have committed the fix (same way as i386 do).

Ruslan