From owner-svn-src-head@FreeBSD.ORG  Thu Oct  1 14:36:15 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 724251065676;
	Thu,  1 Oct 2009 14:36:15 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au
	[211.29.132.187])
	by mx1.freebsd.org (Postfix) with ESMTP id E6DE38FC12;
	Thu,  1 Oct 2009 14:36:14 +0000 (UTC)
Received: from c122-107-125-150.carlnfd1.nsw.optusnet.com.au
	(c122-107-125-150.carlnfd1.nsw.optusnet.com.au [122.107.125.150])
	by mail06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	n91Ea6A1015650
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 2 Oct 2009 00:36:09 +1000
Date: Fri, 2 Oct 2009 00:36:06 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
In-Reply-To: <86eipno12p.fsf@ds4.des.no>
Message-ID: <20091002002534.D21507@delplex.bde.org>
References: <200910010243.n912hpSM034846@svn.freebsd.org>
	<86eipno12p.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="0-1094142715-1254407766=:21507"
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Coleman Kane <cokane@freebsd.org>
Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2009 14:36:15 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-1094142715-1254407766=:21507
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 1 Oct 2009, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote:

> Coleman Kane <cokane@FreeBSD.org> writes:
>> -=09=09if (sc->ndis_80211 && vap)
>> +=09=09if ((sc->ndis_80211 !=3D NULL) && (vap !=3D NULL))
>
> sc->ndis_80211 is an int.  NULL is a pointer.

Also, the number of style bugs was doubled on (almost?) every changed line
by adding 2 sets of unnecessary parentheses.

Bruce
--0-1094142715-1254407766=:21507--