From owner-cvs-src@FreeBSD.ORG Thu Nov 4 21:30:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EDE316A4CE; Thu, 4 Nov 2004 21:30:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B70943D54; Thu, 4 Nov 2004 21:30:19 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iA4LUJdl039607; Thu, 4 Nov 2004 21:30:19 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iA4LUIkw039606; Thu, 4 Nov 2004 21:30:18 GMT (envelope-from glebius) Message-Id: <200411042130.iA4LUIkw039606@repoman.freebsd.org> From: Gleb Smirnoff Date: Thu, 4 Nov 2004 21:30:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2004 21:30:19 -0000 glebius 2004-11-04 21:30:18 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Partically backout previous commit. Since _callout_stop_safe() clears out c->c_func, we can't take it after callout_stop(). To take it before we need to acquire callout_lock, to avoid race. This commit narrows down area where lock is held, but hack is still present. This should be redesigned. Approved by: julian (mentor) Revision Changes Path 1.86 +7 -2 src/sys/netgraph/ng_base.c