From owner-svn-src-all@freebsd.org Tue Nov 21 01:46:37 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BCB3DBBEB5 for ; Tue, 21 Nov 2017 01:46:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C758B7711C for ; Tue, 21 Nov 2017 01:46:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id m11so5880515iti.1 for ; Mon, 20 Nov 2017 17:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=EvVpkClr5S/1D+yZ4XXljZzJzYHWhug2R8ro14IVsGE=; b=GWaFouNqDLKuIakjH9gWMeOGTN3P2NaCdVuAS6sRn9BcTBaCDDbJ5/xa4UwjQUvfFi DsPIy5QZRzObYbNlmEWcUIDg6bBGbGYNDgFxajp5iOIpmwZypWGoIT2/EkLYws6KzX7Y oXoAlJNhV+qdihs1G63/YHMQi4/GKdNVc+urkCl9rdXCy7ucnFDbj8KoztXV8aTe/nTJ cCLzwoZNklsz+feD2raXt7LFWO48IRVclXoQdy374tOVL24EZSTaND+S3c4kQWWaHRUW 3rwxtH7TN1TRDKkt/heps+tqvZkWNScR1qjRwEVnu7bCYzYuSPAXaySftjCf/2YeSr2l 6cEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=EvVpkClr5S/1D+yZ4XXljZzJzYHWhug2R8ro14IVsGE=; b=oIt7x0LnBg+BAd26JpX0unOB30tMDOUA+beqwoCJ4p0WNWbhxKP2syg1MY9BqyoTiU 8PLOaTkHAk2GlPvAHJM5MzmPKvxKJO67nEUKCKLL+Zw4IOJqzEmg24vCz46cRi02EUNq B7l+pa0h3PfkA2KIvTZ/69yJtbeg6vbRdRcxjSkWpEIhQlZJ739SDaj3QjLMctjL+e0B eIFgrrqCG5/0A/oLGxrOPUE3lJsfsuTfSterxaM5UI5k6caqmD7+pjvl/MvyQridYeRV dW2VGog/uOUlYOHdjJ+JHeE9QG6eUzLk38p4rHhpAzb5pjPJmEifxmy5hRPd2fXE/IJH FK+g== X-Gm-Message-State: AJaThX7Z6fm1gZc/UvOgfr1dmRilE94TEdIlPqgP2h2vk9Oj2fZBP8DK druMfPCjZn3HN3Q1xyWKda+Ug/5/o9k9SjsrryW4iQ== X-Google-Smtp-Source: AGs4zMa+C8QVFeWnX0Oa9H7QM/anlrGdY+uMiNPdvhHSfTDSCBeH2PfHbXs6o+AsdjEGCzZvO08ai4rBqW6Czwyoq3k= X-Received: by 10.36.94.129 with SMTP id h123mr16195675itb.64.1511228795938; Mon, 20 Nov 2017 17:46:35 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Mon, 20 Nov 2017 17:46:34 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:48:c6cd:13c1:8d48] Received: by 10.79.108.204 with HTTP; Mon, 20 Nov 2017 17:46:34 -0800 (PST) In-Reply-To: References: <201711202255.vAKMt2nP014201@repo.freebsd.org> From: Warner Losh Date: Mon, 20 Nov 2017 18:46:34 -0700 X-Google-Sender-Auth: cjeYAgCjrPa5oJoVTPgvwHZo7-k Message-ID: Subject: Re: svn commit: r326039 - in head: etc/mtree usr.bin/head usr.bin/head/tests To: Alan Somers Cc: Ed Maste , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 01:46:37 -0000 On Nov 20, 2017 6:36 PM, "Alan Somers" wrote: On Mon, Nov 20, 2017 at 6:32 PM, Ed Maste wrote: > On 20 November 2017 at 17:55, Alan Somers wrote: >> Author: asomers >> Date: Mon Nov 20 22:55:02 2017 >> New Revision: 326039 >> URL: https://svnweb.freebsd.org/changeset/base/326039 >> >> Log: >> Add ATF tests for head(1) >> >> Submitted by: Fred Schlecter >> Reviewed by: asomers, jilles >> MFC after: 3 weeks >> Differential Revision: https://github.com/freebsd/ freebsd/pull/127 > > It's certainly a good idea to capture the source of changes that come > in via GitHub pull requests, but the 'Differential Revision' field is > specifically for reviews in our own hosted Phabricator instance. > > We don't have an officially established metadata field for changes > that come in via pull requests at the moment. I'd suggest we just go > with: > Pull request: https://github.com/freebsd/freebsd/pull/127 Are there any automated tools that care about the "Differential Revision" field? If so, they should be able to tell the difference between GitHub revisions and Phabricator revisions based on the URL. Using "Differential Revision" instead of "Pull request" is handy, because it's part of the standard commit template, which encourages consistency. We should add Pull Request: to the template. Differential Revision really is a specific thing for phabricator... Warner