From owner-freebsd-stable@FreeBSD.ORG Mon Apr 26 16:30:33 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0423106566C; Mon, 26 Apr 2010 16:30:33 +0000 (UTC) (envelope-from julianelischer@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id DBBBB8FC18; Mon, 26 Apr 2010 16:30:32 +0000 (UTC) Received: by fxm15 with SMTP id 15so129106fxm.13 for ; Mon, 26 Apr 2010 09:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=yZnnSNr3LsoqlgjgNG2Mw1WfGJ1j6aB7j/XbS7MhCOU=; b=hnzjtoLDNF67QKKMPxNfImNQYoaIqH+GZaO5MtFxxvR1JpNn9mJo82x4/m5XdPWtWG ea2llOrTFc23OCbcABi7RN54HVX92uSLe3Z5H3zgW/lG+R6ksL6ozjEZ+kj9DJ/mFHwk V6Ctrqpc6nxX1+omhdaTJCVZsGaJUZPjfJhOw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=kRn972FUuk9ZwXdyCsqxHvEE9Cr1yuwM3p1T2XNUIdlzgAHVbQovB9scNr4VfISG9v /b5B69bO5FNJ0hbrHNSm+szgo/fGkvlv7HelobC8rj2xpKINKLeljji28CgtyMq7Miil POr2x/bjOA33noMX96KzwoLYrXo6QaR+/cvu4= Received: by 10.87.69.8 with SMTP id w8mr7730196fgk.58.1272297763037; Mon, 26 Apr 2010 09:02:43 -0700 (PDT) Received: from julian-mac.elischer.org (h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137]) by mx.google.com with ESMTPS id 4sm6915980fge.13.2010.04.26.09.02.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 26 Apr 2010 09:02:40 -0700 (PDT) Sender: Julian Elischer Message-ID: <4BD5B91B.2050606@elischer.org> Date: Mon, 26 Apr 2010 09:02:35 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Stefan Esser References: <4B28F841.1070900@skylinetele.com> <4BD54AC7.7090301@FreeBSD.org> In-Reply-To: <4BD54AC7.7090301@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: "Li, Qing" , freebsd-stable@freebsd.org, "Prokofiev S.P." , freebsd-net@freebsd.org, Qing Li , freebsd-current@freebsd.org, Marin Atanasov Subject: Re: net/mpd5, ppp, proxy-arp issues X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 16:30:33 -0000 On 4/26/10 1:11 AM, Stefan Esser wrote: > Am 22.04.2010 20:43, schrieb Marin Atanasov: >> Hello, >> >> Thanks a lot for the patch, Qing! >> >> It works fine. However I've noticed one thing, after I start mpd5 and >> connect to my home network: >> >> kernel: WARNING: attempt to domain_add(netgraph) after domainfinalize() >> >> Not very sure if this is something to worry about or not? > > There was a problem with the initialization order of network "domains", > which caused kernel crashes with ISDN+INET6 some two years ago. The > reason was, that there was an implicit assumption, that all domains > were initialized when the network interfaces are initialized, with > NULL dereferences if domains are added (and relevant to a device) > after the device has been initialized. > > I debugged this problem and prepared a patch for discussion, which > later was committed by Max Laier (if memory serves me right). The > message was added in order to identify further situations, where > network domains are added after network interfaces have been > initialized. This message ought to be informational right now, since > the interface init is repeated whenever a network domain is added > as part of above mentioned patch. Init order should be fixed, if > this message is printed for compiled in drivers, but in case of a > kernel module (like netgraph) that adds a domain, it is unadvoidable > that the init order is reversed. > > Perhaps the message should be made conditional on the start-up of > the kernel not having finished, or it should be completely removed, > since time has shown, that the init order is correct in general. > > I'll remove that message (or make it conditional on "bootverbose") > unless there is opposition to this change ... please do.. it's an unavoidable thing that domains added after boot are done after boot completes :-) > Regards, STefan > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"