Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Feb 2013 12:28:32 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Martin Wilke <miwi@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r312091 - in head/audio: . gtmixer
Message-ID:  <20130212122832.GA82139@FreeBSD.org>
In-Reply-To: <201302121005.r1CA5iJj080078@svn.freebsd.org>
References:  <201302121005.r1CA5iJj080078@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 12, 2013 at 10:05:44AM +0000, Martin Wilke wrote:
> New Revision: 312091
> URL: http://svnweb.freebsd.org/changeset/ports/312091
> 
> +PORTNAME=	gtmixer
> +PORTVERSION=	1.0.2
> +CATEGORIES=	audio
> +MASTER_SITES=	http://github.com/svagner/gtmixer/archive/
> +DISTNAME=	${PORTVERSION}

Perhaps USE_GITHUB could be used here?..

> +WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
> +FETCH_ARGS=	-Fpr

... which could also release you from setting FETCH_ARGS.  (Setting WRKSRC
also looks weird, but I'm not sure yet if it can be omitted.)

> +do-install:
> +	@${MKDIR} ${PREFIX}/share/gtmixer
> +	@${CP} -r ${WRKSRC}/icons ${PREFIX}/share/gtmixer/
> +	@${INSTALL_MAN} ${WRKSRC}/gtmixer.1 ${MAN1PREFIX}/man/man1

We do not mute installation commands (muting MKDIR is fine).

> +++ head/audio/gtmixer/pkg-descr	Tue Feb 12 10:05:43 2013	(r312091)
> @@ -0,0 +1,4 @@
> +GTMixer is a free, simple graphical mixer for FreeBSD.
> +Based at GTK 2.0 Lib.

Bad grammar, bogus use of contraction and capitalization; also it seems port
description could be augmented a bit.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130212122832.GA82139>