From owner-cvs-all  Mon Jul  1 14:44:35 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3AB1137B400; Mon,  1 Jul 2002 14:44:32 -0700 (PDT)
Received: from turbine.trit.org (turbine.trit.org [63.198.170.141])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8AE3E43E09; Mon,  1 Jul 2002 14:44:31 -0700 (PDT)
	(envelope-from dima@trit.org)
Received: from turbine.trit.org (localhost [127.0.0.1])
	by turbine.trit.org (Postfix) with ESMTP
	id 880793E1E; Mon,  1 Jul 2002 21:44:30 +0000 (UTC)
To: sheldonh@freebsd.org, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: doc/en_US.ISO8859-1/share/sgml authors.ent doc/en_US.ISO8859-1/articles/contributors article.sgml 
In-Reply-To: <20020701154046.GN85531@starjuice.net>; from sheldonh@starjuice.net on "Mon, 1 Jul 2002 17:40:46 +0200"
Date: Mon, 01 Jul 2002 21:44:30 +0000
From: Dima Dorfman <dima@trit.org>
Message-Id: <20020701214430.880793E1E@turbine.trit.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Sheldon Hearn <sheldonh@starjuice.net> wrote:
> On (2002/07/01 08:30), Johan Karlsson wrote:
> 
> >   Modified files:
> >     en_US.ISO8859-1/share/sgml authors.ent 
> >     en_US.ISO8859-1/articles/contributors article.sgml 
> >   Log:
> >   Move myself from additional contributors to developers section.
> >   Add authors entry for myself.
> >   
> >   Reviewed by:    sheldonh (mentor)
> >   Approved by:    sheldonh (mentor)
> 
> I have explained to Johan that Reviewed is not required when Approved is
> given.

Isn't this backwards?  "Reviewed by" implies "Approved by", but not
the other way around; a maintainer (or mentor) might "Approve" a patch
without necessarily looking at ("Reviewing") it, but someone that
"Reviewed" a patch always "Approves" it.  The text you proposed for
the Committers' Guide has the same problem.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message