From owner-freebsd-net Mon Oct 14 20:53:44 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 997B537B401; Mon, 14 Oct 2002 20:53:43 -0700 (PDT) Received: from tesla.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id C868443ECF; Mon, 14 Oct 2002 20:53:42 -0700 (PDT) (envelope-from bmilekic@unixdaemons.com) Received: (from bmilekic@localhost) by tesla.distributel.net (8.11.6/8.11.6) id g9F3uAI60012; Mon, 14 Oct 2002 23:56:10 -0400 (EDT) (envelope-from bmilekic@unixdaemons.com) Date: Mon, 14 Oct 2002 23:56:10 -0400 From: Bosko Milekic To: John Baldwin Cc: net@FreeBSD.org Subject: Re: Rename of MSIZE kernel option.. Message-ID: <20021014235610.A59973@unixdaemons.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from jhb@FreeBSD.org on Mon, Oct 14, 2002 at 04:15:12PM -0400 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Not that my opinion really holds much weight with you guys but for what it's worth, I think the change would be gratuitist. 1. MSIZE has been around forever. 2. The argument that sys/sys/mbuf.h should have MSIZE removed/changed because some other code may use it is fallacious. The "other code" should be careful not to use a constant that has been so named for the longest time I can recall. On Mon, Oct 14, 2002 at 04:15:12PM -0400, John Baldwin wrote: > Would people be open to renaming the 'MSIZE' kernel option to something > more specific such as 'MBUF_SIZE' or 'MBUFSIZE'? Using 'MSIZE' can > break other places in the kernel. For example, ISA device ivars have > an ivar for the size of a memory resource called 'MSIZE' and the kernel > option causes breakage in src/sys/isa/isavar.h: > > ISA_ACCESSOR(msize, MSIZE, int) > > when ISA_ACCESSOR is properly defined via __BUS_ACCESSOR() rather than > homerolling a private copy of __BUS_ACCESSOR(). For now I've fixed it > to rename the ISA ivar to ISA_IVAR_MEMSIZE but MSIZE seems to be too > generic a name for a kernel option and it would be nice to avoid this > problem in the future. > > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ -- Bosko Milekic * bmilekic@unixdaemons.com * bmilekic@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message