From owner-svn-src-head@FreeBSD.ORG Tue Apr 7 14:24:32 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D1057B54 for ; Tue, 7 Apr 2015 14:24:32 +0000 (UTC) Received: from nm15.bullet.mail.bf1.yahoo.com (nm15.bullet.mail.bf1.yahoo.com [98.139.212.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 783D1AA2 for ; Tue, 7 Apr 2015 14:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1428416340; bh=+1+7gvxfmODc9UFlt3AtEkjxWrDkOShuRVwl8N68bdc=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=eoX99GUwPHMfMDJD9Z8NWttO6m7gtPxG7sf8156N07VMde4P0s4cXt5H/JJmOkKepgmCSc+8pVfoQyCn9Cpu+G4QNWavX28ues9K7ldDmw1Jhw3JnNF+HjRZ195+kLgnQLdzd405pZHLqmhFygw0QwZL0Ub1NJlDceNuMmNaO7IXfvLwZURV4hanZ/Z5/0GVcIUE1BgR+yCDFm1nLu1lP6fC77OIeAIC0zlPv1dkeYpXSBcDYU+/GsJZCad5Ap/bWcfC1wB9vDtwAo0UP9RohUTBP/YQVKMEwRlEcmtSpfe1iGnwA8hhCVQEcBI1n6u51TJxrcmBWn4eY83yJvhNgw== Received: from [66.196.81.170] by nm15.bullet.mail.bf1.yahoo.com with NNFMP; 07 Apr 2015 14:19:00 -0000 Received: from [98.139.213.15] by tm16.bullet.mail.bf1.yahoo.com with NNFMP; 07 Apr 2015 14:19:00 -0000 Received: from [127.0.0.1] by smtp115.mail.bf1.yahoo.com with NNFMP; 07 Apr 2015 14:19:00 -0000 X-Yahoo-Newman-Id: 501990.549.bm@smtp115.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: h2ow45oVM1nVNY7rciXob4yCiKTk_Qn2FF0SEakdnS3zF69 L1yX4C6yL0TxNRBhzAViBuKEb1llM6qvIH4tDTkHYIDgTs5t7YUnegjUIRLL v9mLahmrrUUgHFNngnKByTAPuP6LyfxUz7V3hmpvcy2VrGApdVk5_7QePmYX vDmPCjkJpKY3KPTXokQ9hNRXOgS5Mof5DWKxQdih77IBhlF1rThboaryBdOF D2Ak3DB9v6IpljxTLTJRsLHM.aY7sodHMh1JWmNmesNSWMh75p6yi2hVVHLi TglE88eoH56F7QSr2xty1n54ntudPPnGplfaWawHZD7JZw9u75C4L1OXkmRj mFH4cgQmXkrlvHQfTXpQYTZGujl3QULKOuNjeZJG1sILfTuG_6xYiKpWJxay lPEbcvKJvwiQyao7JCqzsFTgET_cgFaG1wIkFgBwEUGNWJY1LMHs3JMYOm61 2EFKTuv1SvgiYSbY1H7al5D4duG3vQmrgloJVRIYRKWzQ.PaKrH7hXmktLW8 5JwCBOuQyTxzfBKpTXYLG9U0k7TPOoavZ X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <5523E766.8010904@FreeBSD.org> Date: Tue, 07 Apr 2015 09:19:18 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eitan Adler Subject: Re: svn commit: r281181 - head/usr.bin/sort References: <201504070117.t371HTlS083981@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2015 14:24:32 -0000 On 04/06/15 23:26, Eitan Adler wrote: > On 6 April 2015 at 21:17, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Tue Apr 7 01:17:29 2015 >> New Revision: 281181 >> URL: https://svnweb.freebsd.org/changeset/base/281181 >> >> Log: >> sort(1): Cleanups and a small memory leak. >> >> Remove useless check for leading blanks in the month name. The >> code didn't adjust len after stripping blanks so even if a month >> *did* start with a blank we'd end up copying garbage at the end. >> Also convert a malloc + memcpy to strdup and fix a memory leak in >> the wide char version if mbstowcs() fails. >> Originally from Andre Smagin. >> >> Obtained from: OpenBSD (CVS rev. 1.2, 1.3) >> MFC after: 1 week > Thanks for porting all these cleanups! > I am not over, but they have started doing many unnecessary changes that I have no interest in. I am also wondering if we should give up the GNU behavior our sort(1) adopted. Pedro.