Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 May 2015 09:26:33 +0000 (UTC)
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r282463 - head/usr.bin/checknr
Message-ID:  <201505050926.t459QXdL063669@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bapt
Date: Tue May  5 09:26:32 2015
New Revision: 282463
URL: https://svnweb.freebsd.org/changeset/base/282463

Log:
  Use stdup(3) and check its return instead from homebrew version using strcpy(3)
  and malloc(3)
  
  Obtained from:	NetBSD

Modified:
  head/usr.bin/checknr/checknr.c

Modified: head/usr.bin/checknr/checknr.c
==============================================================================
--- head/usr.bin/checknr/checknr.c	Tue May  5 09:24:29 2015	(r282462)
+++ head/usr.bin/checknr/checknr.c	Tue May  5 09:26:32 2015	(r282463)
@@ -574,7 +574,8 @@ addmac(const char *mac)
 	dest = src+1;
 	while (dest > loc)
 		*dest-- = *src--;
-	*loc = strcpy(malloc(3), mac);
+	if ((*loc = strdup(mac)) == NULL)
+		err(1, "strdup");
 	ncmds++;
 #ifdef DEBUG
 	printf("after: %s %s %s %s %s, %d cmds\n",



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201505050926.t459QXdL063669>