From owner-svn-ports-head@freebsd.org Mon Oct 17 17:02:02 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46698C15288; Mon, 17 Oct 2016 17:02:02 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 018DA302; Mon, 17 Oct 2016 17:02:02 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 72958BDCF7; Mon, 17 Oct 2016 19:02:00 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 45D51BDCF1; Mon, 17 Oct 2016 19:02:00 +0200 (CEST) Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org> Date: Mon, 17 Oct 2016 19:01:50 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PNSEcMtdkMjOg2JBxOTM3vHLxXQqHVhvl" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 17:02:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PNSEcMtdkMjOg2JBxOTM3vHLxXQqHVhvl Content-Type: multipart/mixed; boundary="Hg4rOF3B1t14ko7jUKFXJipKxVXimTx7p"; protected-headers="v1" From: Mathieu Arnold To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org> Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> In-Reply-To: <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> --Hg4rOF3B1t14ko7jUKFXJipKxVXimTx7p Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 17/10/2016 =C3=A0 18:31, John Marino a =C3=A9crit : > > > On 10/17/2016 11:28, Mathieu Arnold wrote: >> Le 17/10/2016 =C3=A0 18:26, John Marino a =C3=A9crit : >>> On 10/17/2016 11:20, Mathieu Arnold wrote: >>>> Le 17/10/2016 =C3=A0 17:55, John Marino a =C3=A9crit : >>>>> On 10/17/2016 10:52, Mathieu Arnold wrote: >>>>>> Le 17/10/2016 =C3=A0 17:15, John Marino a =C3=A9crit : >>>>>>> Apparently USES=3Dpathfix and USES=3Dautoreconf can't be used >>>>>>> together, so >>>>>>> the pkgconfig directory is now passed via MAKE_ARGS >>>>>> >>>>>> That is mostly not true. What usage makes it so that they do not >>>>>> work >>>>>> together ? >>>>> >>>>> The results suggest that "${WRKSRC}/configure" was modified, then >>>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that the >>>>> pkgconfig path change was reverted. >>>>> >>>>> That's why I had to replace pathfix with MAKE_ARGS. >>>> >>>> No, USES=3Dpathfix changes the content of PATHFIX_MAKEFILEIN, which = by >>>> default, is Makefile.in. It won't change configure unless you set >>>> PATHFIX_MAKEFILEIN=3Dconfigure. >>>> >>> >>> Well, I didn't add MAKE_ARGS for fun. >>> After adding USES+=3Dautoreconf, the build broke. pathfix was still = in >>> place. You can reproduce by adding pathfix back before "python" and >>> commenting out the new MAKE_ARGS line I added and check with >>> "check-plist" It's easy to confirm. >> >> I never said your fix did not work or was not right, I said USES=3Dpat= hfix >> won't touch configure. >> > > Ah, that's the issue. I misspoke. I didn't mean "configure", I mean > the Makefile all along. So you agree in this case pathfix and > autoreconf aren't compatible, right? Not at all, if the file patched was Makefile.in, set PATHFIX_MAKEFILEIN=3DMakefile.am and it will work. --=20 Mathieu Arnold --Hg4rOF3B1t14ko7jUKFXJipKxVXimTx7p-- --PNSEcMtdkMjOg2JBxOTM3vHLxXQqHVhvl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJYBQQAXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85INp0QAI4jRXg9DqhYK4HC01OzdO0+ ssR2rhljrHyq+L7gxBK/4Ls4HrnDtYipiFqdf5rv3cuwPlGJWYVoj4FTJOSSIAqU MJsKldA8sMFGl1DiNq40tG+NCHJnXrkeXdaqVWMO4fJncP9ABdhQ/35e9aRH4P29 UE8iJd/4fNVuvc2DPKBGlKHpUobNfdDFlRnOg/3B16O49s8KWEnAP6srZpgBeRms gBKUjjq2pV8vckW+Sh0dOXbq6p42ebB6WHIksQfvIvuSmN5rJibheRvRTC4//lD3 pEUJlTCcDg7AWDODDW6hf4B8jdcACDRu9fCxV2B1Fl7anw21WIEZmhgJ/U9tnaHB cqNKVoyOWCEMd0EnDubyb2mOF30p0N1KRRkWLgTwW/HwJIN/yuKqIIGy100C3aRr oJFmv25l2ha6XtibZal7Rkt62teh82a8+o2Qg5yMcNXkSU6iS1MPFF1tmkVHqrjo 26qytea0CmEw7Gi9R/tbhgklM2kEdQdc5sId1XRusrr0+pQg3nATst+XY2oHcf5P SrVzS4RPGMhdzAQKzBzSOWZInVorpsnDJgguxFGZtV7/VlWSDbRsvKhRLBKG0I0k 83Co73oOQCPUVA1pVQcpYGNNPpup9ieBb3oOF27XKq6q3Md+vszdkP8kk7fn0EFb wkTpu1k+gqum7F6JQSai =5DA1 -----END PGP SIGNATURE----- --PNSEcMtdkMjOg2JBxOTM3vHLxXQqHVhvl--