From owner-freebsd-bugs@freebsd.org  Wed Aug 17 15:15:07 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 29ABFBBDFD4
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed, 17 Aug 2016 15:15:07 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 197811799
 for <freebsd-bugs@FreeBSD.org>; Wed, 17 Aug 2016 15:15:07 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7HFF6vG030493
 for <freebsd-bugs@FreeBSD.org>; Wed, 17 Aug 2016 15:15:06 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 204005] [patch][pf] PF_ANEQ macro improperly compare IPv4
 packets.
Date: Wed, 17 Aug 2016 15:15:07 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: commit-hook@freebsd.org
X-Bugzilla-Status: Closed
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-204005-8-S9UxbAp1OB@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204005-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-204005-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Aug 2016 15:15:07 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204005

--- Comment #3 from commit-hook@freebsd.org ---
A commit references this bug:

Author: kp
Date: Wed Aug 17 15:14:21 UTC 2016
New revision: 304293
URL: https://svnweb.freebsd.org/changeset/base/304293

Log:
  MFC r289932, r289940:

  PF_ANEQ() macro will in most situations returns TRUE comparing two identi=
cal
  IPv4 packets (when it should return FALSE). It happens because PF_ANEQ()
doesn't
  stop if first 32 bits of IPv4 packets are equal and starts to check next =
3*32
  bits (like for IPv6 packet). Those bits containt some garbage and in resu=
lt
  PF_ANEQ() wrongly returns TRUE.

  Fix: Check if packet is of AF_INET type and if it is then compare only fi=
rst
32
  bits of data.

  PR:             204005
  Submitted by:   Mi?osz Kaniewski

Changes:
_U  stable/10/
  stable/10/sys/net/pfvar.h

--=20
You are receiving this mail because:
You are the assignee for the bug.=