From owner-cvs-all Tue Dec 12 13:10:38 2000 From owner-cvs-all@FreeBSD.ORG Tue Dec 12 13:10:32 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id EDB8A37B400; Tue, 12 Dec 2000 13:10:31 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eBCLARE97259; Tue, 12 Dec 2000 13:10:27 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.0) id eBCL9f820118; Tue, 12 Dec 2000 13:09:41 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Tue, 12 Dec 2000 13:09:41 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Matthew Jacob Subject: Re: cvs commit: src/sys/sys kernel.h eventhandler.h src/sys/kern Cc: Peter Jeremy , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Poul-Henning Kamp Sender: jhb@foo.osd.bsdi.com Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 12-Dec-00 Matthew Jacob wrote: > >> On 12-Dec-00 Matthew Jacob wrote: >> > >> >> I wasn't sure if this breakage had been seen by anyone else. The fix is >> >> to >> >> have agp include sys/proc.h. I'll commit in a second.. >> > >> > I believe the issue here is that poul *removed* sys/proc.h (from this and >> > tty_cons.c). >> >> It was hidden because sys/mutex.h includes sys/proc.h, and >> sys/eventhandler.h >> used to include sys/mutex.h. Blech. > > Well, what's the right answer. Aside from the annoyance of breakage from a > well intentioned change by Poul, what's the *desired* goal here wrt include > files if you want to reference curproc? You use . However, due to the nested include ugliness, Poul's script found that sys/proc.h was unneeded. > -matt -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message