From nobody Wed May 27 14:59:23 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQXp35SJPz6f8v8 for ; Wed, 27 May 2026 14:59:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQXp31Y1cz3HNm for ; Wed, 27 May 2026 14:59:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779893963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NXKmDfJUBgz5dDEuZCOTmeTpM2CDy6WHGP3pe9gWxm0=; b=pVT2pm5aBDB0nvFoQx/HoQNdnZTIRxf9CkAM/bA18H3+GCauaCSB4jo2GRu/qyv+ZVVXN/ G+t9i5djoQau+9Q8nRoSqJ3AkOu8VtjpyLyVvwsPOfYhHAav3M9aj63Tf94qbt44CHLKJU vM4khdOJo6X7xe3NGeBJ0tqheOyUEiFflDES+TbMJ3dwxnB1CijfsnpqlUa1/YItF/3iE4 +Ib98W+k6YDNUW4mGAm/SXrAjo4pBkeY9wX3Z7PpUw3uwr6DuVseP+jGlxSAExOB/PXVzg zKfnkBqg8ivrkEOjENizy/JXBScLff6DBk1NFKjhZC7C4pKQCixPEDs5AHLgzQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779893963; a=rsa-sha256; cv=none; b=oiUx9iC0P9Vn4O77T5Csg/jeBW2hI+lIc3bYg91eKOoiyxo3HZnDCDFZimMW2cJfZcBgQO /oJUfG6F0M2NtXHw0VyMGt2Tl+DA3Il5MQt49XZ3bQ9XbebuqbVIG7z5S0IcM/RGMjny4q wv6qhLxVPr/Lzm+c8l21X/iIlx8PrOtm2EucaaypUtmF7zSAksMfh8i/2+WydXv5dbikZE 1WBKkMtBnQzHLsvy1cKDxfXCR+o/2KCIAfqwfEEiVAdXJ5FI6pogMudnVkIHL6Ami+j1Ow lsrG+lP2ys0tsFAzXqzIzxEPHsEQ0Haa/WoeTrJyH6xUAr6A+P+bnNDQuu64PA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779893963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NXKmDfJUBgz5dDEuZCOTmeTpM2CDy6WHGP3pe9gWxm0=; b=kKayM7WUAtMp4jkuOJmdLrushyC0bnuRzftEJvsZDJBfb+jpOmHnmMuF7b7o/X3F5PUrMs LS4Aihm5/qtgMWJjc2J6UKz+05ozsOfnJD30bdtl5RXLwGstsqUPHKaWlFKI6vVDTh9WT+ dKNFGCh8AnqtBJR+IyRrNZLKVbwN7/z7MmVkOx8+HFgcyrTSWKPr3bCnZaxNo2tv1MhF5x aOhW7i4V4C8Nc9Ynswy7wBASRwudJczJyzbgH1xyR05HCdF3ljU7RY18u0VY++byOvukXJ FsE2coGck1MN3OxeZvGh1sHwkzCq9vwfMx+Rjf/FLFahp3GqmTPrKnJNw1o1rQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQXp30wZKz13Pb for ; Wed, 27 May 2026 14:59:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21e60 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 14:59:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 59d67f2868b1 - main - amd64/i386: Remove dead code to clear XSAVE header List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 59d67f2868b17dc6ae897a3afd3ec4d96301e160 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 14:59:23 +0000 Message-Id: <6a1706cb.21e60.4bcaaba0@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=59d67f2868b17dc6ae897a3afd3ec4d96301e160 commit 59d67f2868b17dc6ae897a3afd3ec4d96301e160 Author: John Baldwin AuthorDate: 2026-03-28 11:19:10 +0000 Commit: John Baldwin CommitDate: 2026-05-27 13:43:46 +0000 amd64/i386: Remove dead code to clear XSAVE header If XSAVE is being used, the XSAVE header will be overwritten either by copying it from the parent thread in copy_thread for user threads, or by a fresh copy from fpu/npx_initialstate on the first use of the FPU for kernel threads. Reviewed by: kib Sponsored by: AFRL, DARPA Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/23 --- sys/amd64/amd64/vm_machdep.c | 6 ------ sys/i386/i386/vm_machdep.c | 6 ------ 2 files changed, 12 deletions(-) diff --git a/sys/amd64/amd64/vm_machdep.c b/sys/amd64/amd64/vm_machdep.c index e37f122dffa3..8121a17d885a 100644 --- a/sys/amd64/amd64/vm_machdep.c +++ b/sys/amd64/amd64/vm_machdep.c @@ -375,18 +375,12 @@ void cpu_thread_alloc(struct thread *td) { struct pcb *pcb; - struct xstate_hdr *xhdr; set_top_of_stack_td(td); td->td_pcb = pcb = get_pcb_td(td); td->td_frame = (struct trapframe *)td->td_md.md_stack_base - 1; td->td_md.md_usr_fpu_save = fpu_save_area_alloc(); pcb->pcb_save = get_pcb_user_save_pcb(pcb); - if (use_xsave) { - xhdr = (struct xstate_hdr *)(pcb->pcb_save + 1); - bzero(xhdr, sizeof(*xhdr)); - xhdr->xstate_bv = xsave_mask; - } } void diff --git a/sys/i386/i386/vm_machdep.c b/sys/i386/i386/vm_machdep.c index 003f00070bff..bf08f7dd3882 100644 --- a/sys/i386/i386/vm_machdep.c +++ b/sys/i386/i386/vm_machdep.c @@ -373,7 +373,6 @@ void cpu_thread_alloc(struct thread *td) { struct pcb *pcb; - struct xstate_hdr *xhdr; /* * The -VM86_STACK_SPACE (-16) is so we can expand the trapframe @@ -384,11 +383,6 @@ cpu_thread_alloc(struct thread *td) VM86_STACK_SPACE) - 1; pcb->pcb_ext = NULL; pcb->pcb_save = get_pcb_user_save_pcb(pcb); - if (use_xsave) { - xhdr = (struct xstate_hdr *)(pcb->pcb_save + 1); - bzero(xhdr, sizeof(*xhdr)); - xhdr->xstate_bv = xsave_mask; - } } void