From owner-freebsd-current@FreeBSD.ORG Thu Sep 7 14:02:04 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C28716A4EA for ; Thu, 7 Sep 2006 14:02:04 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id B788143D46 for ; Thu, 7 Sep 2006 14:02:02 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 60200 invoked from network); 7 Sep 2006 13:46:52 -0000 Received: from dotat.atdotat.at (HELO [62.48.0.47]) ([62.48.0.47]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 7 Sep 2006 13:46:52 -0000 Message-ID: <45002659.9050203@freebsd.org> Date: Thu, 07 Sep 2006 16:02:01 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050217 MIME-Version: 1.0 To: Jack Vogel References: <2a41acea0609011551v40338539u4eef48d091dd12ab@mail.gmail.com> <44F9384C.9070902@freebsd.org> <2a41acea0609021741y481a04c0r42902166eaba78d7@mail.gmail.com> <20060905162542.GA63869@hub.freebsd.org> <44FDAF08.20407@freebsd.org> <20060905182313.GA85389@hub.freebsd.org> <44FDD65C.6070109@freebsd.org> <2a41acea0609051410i7d968b88ocf240514ff410452@mail.gmail.com> <44FDECB6.2040304@freebsd.org> <2a41acea0609051523w55939cdeu71ee9857f40d1294@mail.gmail.com> In-Reply-To: <2a41acea0609051523w55939cdeu71ee9857f40d1294@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net , freebsd-current , Prafulla Deuskar Subject: Re: RFC: TSO patch for current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2006 14:02:04 -0000 Jack Vogel wrote: > On 9/5/06, Andre Oppermann wrote: >> > If you do the ifconfig changes there will need to be a small amount of >> > code added to em_ioctl() but it should be trivial. >> > >> > You want me to reissue a driver patch with changes for your code? >> >> Yes, please do so. I've got a dual-em card which I can test with myself. > > OK, attached new patch, this one even has the ioctl change so when > you get the ifconfig change in it will be ready. The TSO code is committed. There has been a slight change with the ifcapabilities to differentiate between TSO for IPv4 and IPv6 which can be set independently. The pseudo-header checksum is always provided in m_pkthdr.csum_data, you don't have to compute it yourself in the driver. TSO for IPv6 is not yet functional as it is missing the in6_pseudo() function and some changes to ip6_output(). I have contacted one of our IPv6 gurus to develop the patches and get it fully functional as well. -- Andre